Skip to content

Address code review feedback: accessibility, z-index fix, and cleanup #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebma merged 3 commits into from
Jan 30, 2026
Merged

Address code review feedback: accessibility, z-index fix, and cleanup #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ebf431
Initial plan
Copilot Jan 30, 2026
ff216ff
Address review feedback: Add motion-reduce classes, fix z-index, corr…
Copilot Jan 30, 2026
bd69be3
Update animations.ts
ebma Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/frontend/src/components/Accordion/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const AccordionContent: FC<AccordionContentProps> = ({ children, className = "",

return (
<div
className="grid transition-[grid-template-rows] duration-300 ease-out"
className="grid transition-[grid-template-rows] duration-300 ease-out motion-reduce:transition-none"
style={{ gridTemplateRows: isOpen ? "1fr" : "0fr" }}
>
<div className="overflow-hidden">
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/components/CollapsibleCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const CollapsibleDetails = ({ children, className = "" }: CollapsibleDetailsProp

return (
<div
className={`grid transition-[grid-template-rows] duration-300 ease-out ${className}`}
className={`grid transition-[grid-template-rows] duration-300 ease-out motion-reduce:transition-none ${className}`}
style={{ gridTemplateRows: isExpanded ? "1fr" : "0fr" }}
>
<div className="overflow-hidden">
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/components/Navbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DesktopNavbar } from "./DesktopNavbar";
import { MobileNavbar } from "./MobileNavbar";

export const Navbar = () => (
<header className="relative z-60">
<header className="relative z-50">
Copy link
Member

@Sharqiewicz Sharqiewicz Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z-60 is a valid value and we should leave it

<div className="hidden sm:block">
<DesktopNavbar />
</div>
Expand Down
4 changes: 2 additions & 2 deletions ...src/components/TokenSelection/NetworkSelectionList/animations/SelectionDropdownMotion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const SelectionDropdownMotion = ({ isOpen, children, className }: Selecti

return (
<div
className={`grid transition-[grid-template-rows] duration-150 ease-out ${className || ""}`}
className={`grid transition-[grid-template-rows] duration-150 ease-out motion-reduce:transition-none ${className || ""}`}
style={{ gridTemplateRows: isOpen ? "1fr" : "0fr" }}
>
<div className="overflow-hidden">
Expand All @@ -28,7 +28,7 @@ export const SelectionDropdownMotion = ({ isOpen, children, className }: Selecti
shouldReduceMotion
? { duration: 0 }
: {
delay: isOpen ? durations.fast : 0,
delay: durations.fast,
duration: durations.fast,
ease: easings.easeOutCubic
}
Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/constants/animations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const easings = {
* Duration guidelines for different interaction types
*/
export const durations = {
fast: 0.15, // 100ms - micro-interactions (hover states)
micro: 0.1, // 150ms - tooltips, dropdowns
micro: 0.1, // 100ms - micro-interactions (hover states)
fast: 0.15, // 150ms - tooltips, dropdowns
normal: 0.2, // 200ms - standard UI animations
slow: 0.3 // 300ms - modals, drawers, complex transitions
};
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/stories/Accordion.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const AccordionWrapper = ({ defaultValue = [], itemCount = 3 }: StoryArgs) => {
};

const InteractiveDemo = () => {
const [openItems, setOpenItems] = useState<string[]>(["item-1"]);
const [openItems] = useState<string[]>(["item-1"]);

return (
<div className="w-full max-w-2xl space-y-4">
Expand Down