Skip to content

Conversation

@Sharqiewicz
Copy link
Member

Summary

  • Fix "Missing required additional data 'assethubToPendulumHash'" error when offramping from AssetHub with an EVM wallet connected

Problem

When a user initiated EUR SELL (offramp) from AssetHub while having an EVM wallet connected, the signing flow failed with:

Missing required additional data 'assethubToPendulumHash' for SELL ramp. Cannot proceed.

Root Cause

In sign.actor.ts:57, the transaction filter always used moneriumWalletAddress (an EVM address) when available:

const signerAddress = executionInput?.moneriumWalletAddress || connectedWalletAddress;

Since DetailsStep always sets moneriumWalletAddress: evmAddress in the form (even for non-Monerium flows), the filter would compare an EVM address against Substrate transaction signers. This comparison always failed, filtering out the assethubToPendulum transaction.

Solution

Use the connected Substrate wallet address for Substrate transactions (Pendulum/AssetHub), and only use moneriumWalletAddress for EVM transactions:

 const signerAddress = isSubstrateTransaction
   ? connectedWalletAddress
   : (executionInput?.moneriumWalletAddress || connectedWalletAddress);

Test plan

  • Connect both Polkadot wallet (Talisman) and EVM wallet
  • Initiate EUR SELL (offramp) from AssetHub
  • Verify signing popup appears for assethubToPendulum transaction
  • Complete the flow without the "Missing required additional data" error

@Sharqiewicz Sharqiewicz requested a review from ebma January 29, 2026 13:26
@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit f3df258
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/697cd6106303cb00084dcc47
😎 Deploy Preview https://deploy-preview-1049--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit f3df258
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/697cd610cb3e610008bcafcb
😎 Deploy Preview https://deploy-preview-1049--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sharqiewicz Sharqiewicz requested a review from gianfra-t January 29, 2026 13:26
@Sharqiewicz Sharqiewicz changed the title Fix assethubToPendulum transaction being filtered out when EVM wallet fix: assethubToPendulum transaction being filtered out when EVM wallet Jan 29, 2026
@Sharqiewicz Sharqiewicz changed the title fix: assethubToPendulum transaction being filtered out when EVM wallet [READY] fix: assethubToPendulum transaction being filtered out when EVM wallet Jan 29, 2026
const signerAddress = executionInput?.moneriumWalletAddress || connectedWalletAddress;
// For substrate networks (Pendulum/AssetHub), always use connectedWalletAddress.
// moneriumWalletAddress is only for Monerium flows with EVM transactions.
const isSubstrateTransaction = tx.network === Networks.Pendulum || tx.network === Networks.AssetHub;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about, instead of checking per network, we check with the transaction data itself? This seems a little more robust to me because otherwise we'd have to touch this check in the future for other substrate networks.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two small improvements and tested if I'm requested to sign. Works as expected 🆗

@ebma ebma merged commit 60242a5 into staging Jan 30, 2026
5 checks passed
@ebma ebma deleted the fix/assethubToPendulum-filtered-out-when-evm-is-connected branch January 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants