-
Notifications
You must be signed in to change notification settings - Fork 3
[READY] fix: assethubToPendulum transaction being filtered out when EVM wallet #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] fix: assethubToPendulum transaction being filtered out when EVM wallet #1049
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| const signerAddress = executionInput?.moneriumWalletAddress || connectedWalletAddress; | ||
| // For substrate networks (Pendulum/AssetHub), always use connectedWalletAddress. | ||
| // moneriumWalletAddress is only for Monerium flows with EVM transactions. | ||
| const isSubstrateTransaction = tx.network === Networks.Pendulum || tx.network === Networks.AssetHub; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about, instead of checking per network, we check with the transaction data itself? This seems a little more robust to me because otherwise we'd have to touch this check in the future for other substrate networks.
ebma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two small improvements and tested if I'm requested to sign. Works as expected 🆗
Summary
Problem
When a user initiated EUR SELL (offramp) from AssetHub while having an EVM wallet connected, the signing flow failed with:
Root Cause
In
sign.actor.ts:57, the transaction filter always usedmoneriumWalletAddress(an EVM address) when available:Since DetailsStep always sets moneriumWalletAddress: evmAddress in the form (even for non-Monerium flows), the filter would compare an EVM address against Substrate transaction signers. This comparison always failed, filtering out the
assethubToPendulumtransaction.Solution
Use the connected Substrate wallet address for Substrate transactions (Pendulum/AssetHub), and only use moneriumWalletAddress for EVM transactions:
Test plan