Conversation
|
@benalleng would Appreciate a review |
Pull Request Test Coverage Report for Build 22934841551Details
💛 - Coveralls |
flake.nix
Outdated
| builtins.removeAttrs pythonWorkspace.deps.all [ "payjoin" ] | ||
| )).overrideAttrs | ||
| { | ||
| # Remove reflexive symlink to prevent fixupPhase failure (noBrokenSymlinks). |
There was a problem hiding this comment.
I would add an additional comment that we believe this is an error upstream to remind us to check the pyproject-nix repo to see if they got a change merged for us to be able to remove this hack
There was a problem hiding this comment.
upstream issue has been Addressed pyproject-nix/pyproject.nix#419
no need for hack anymore
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
Looking good, go ahead and make an issue upstream and link it in the comment about the preFixup phase hack to
Adds `nix develop .#python` for payjoin-ffi/python work. Provides uv, Python, and Rust MSRV in one shell. Co-Authored-By: Brandon Lucas <thebrandonlucas@users.noreply.github.com>
There was a problem hiding this comment.
should we make the script in contrib/test.sh also what runs in CI python.yaml to keep changes consistent or keep current worklow
Yes, we should update the CI.
We should also add similar contrib/test.sh helper scripts for the other language bindings for consistency.
4 participants
Adds
nix develop .#pythonfor payjoin-ffi/python work. Provides uv, Python, and Rust MSRV in one shell.supersede #864
went through comments and followed the nix2python approach as suggested by Yuval in PR
Address #457 (comment)
Note to reviewers:
should we make the script in contrib/test.sh also what runs in CI python.yaml to keep changes consistent or keep current worklow
co authored using claude sonnet 4.6
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.