feat: uniqCount aggregation #298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 71.06% 71.25% +0.18%
==========================================
Files 201 201
Lines 14773 14842 +69
==========================================
+ Hits 10498 10575 +77
+ Misses 3527 3519 -8
Partials 748 748 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheb0
force-pushed
the
295-unique-count
branch
3 times, most recently
from
6b82090 to
10737f2
Compare
cheb0
force-pushed
the
295-unique-count
branch
from
2ed2787 to
025ec18
Compare
cheb0
force-pushed
the
295-unique-count
branch
from
db9b3a3 to
5bb3020
Compare
forshev
approved these changes
Dec 26, 2025
| } | ||
| if errMessage == consts.ErrTooManyFieldValues.Error() { | ||
| return nil, source, fmt.Errorf("store forbids aggregation request: %w", consts.ErrTooManyFieldValues) | ||
| } |
Contributor
There was a problem hiding this comment.
we need to check new resp.Code later as well. on line 614-625
| aggs[i] = seq.AggregatableSamples{ | ||
| SamplesByBin: to, | ||
| NotExists: agg.NotExists, | ||
| ValuesPool: stringPool, |
Contributor
There was a problem hiding this comment.
nit: seem like we can just do ValuesPool: agg.ValuesPool, and remove stringPool variable
| } | ||
| for idx := range hist.Values { | ||
| h.Values[idx] = struct{}{} | ||
| } |
Contributor
There was a problem hiding this comment.
nit: seems like we can use maps.Copy here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #295