feat: include has_binaries flag in build spec#1278
Merged
AbhinavPradeep merged 10 commits intomainfrom Feb 4, 2026
Merged
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
changed the title
behnazh-w
changed the base branch from
main
to
abhinav/fix-gen-build-spec-bugs
behnazh-w
reviewed
Jan 13, 2026
Member
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
Can you please add an integration test for a Python package that includes binaries, to test this new field in the spec?
behnazh-w
changed the base branch from
abhinav/fix-gen-build-spec-bugs
to
main
behnazh-w
reviewed
Jan 20, 2026
Member
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
Right now all the integration tests are testing pure Python packages. How about adding pkg:pypi/cryptography@46.0.3 as a new integration test, which releases non-pure packages?
behnazh-w
reviewed
Jan 20, 2026
Contributor
Author
Actually I did add |
AbhinavPradeep
force-pushed
the
abhinav/include-has-binaries-flag
branch
from
61d9fbe to
452c46d
Compare
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
…he build_requires. Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
AbhinavPradeep
force-pushed
the
abhinav/include-has-binaries-flag
branch
from
037628f to
975c7cf
Compare
…ommand. Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
behnazh-w
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a has_binaries flag to the build spec. This helps differentiate between pure and non-pure Python wheels.
Description of changes