os-nextcloud-backup Only back up when local file is newer than remote#5213
Open
Nuadh123 wants to merge 8 commits intoopnsense:masterfrom
Open
os-nextcloud-backup Only back up when local file is newer than remote#5213Nuadh123 wants to merge 8 commits intoopnsense:masterfrom
Nuadh123 wants to merge 8 commits intoopnsense:masterfrom
Conversation
contents of /conf/backup/
mtime. Only upload if remote file is older than local
Contributor
Author
|
This will break setups that rely on nextcloud plugin "retention", as it will stop uploading the same content every day to the current file. |
Contributor
Author
|
This also fixes a "bug" (more of an annoyance), where the backup upload completes, but raises an exception, due to the upload code using the curl_request function that only accepts http code 200, 201 and 207 as success.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #5200
Checks local filemtime, compares with remote file getlastmodified, only uploads if filemtime > getlastmodified