dns/ddclient hetzner existing record update patch #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added workaround for API bug on update record. Thanks to @ArcanConsulting
Added LOG_NOTICE for deletion.
Member
|
wouldn't it be better to open a ticket at their end, it feels rather weird to patch the caller in this case (assuming its a bug and not a documented change of behavior) |
Author
|
You are right, I've contacted the hoster again. I'll write it correct. |
Updated _update method. No workaround needed.
jnikodemus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ddclient update Hetzner for new API
Reference
pull#5082
issue#5187
Problem
The actual update method returns code 200 for an update, because it doesnt use the right entrypoint.
Fix
Changed the API entrypoint "actions" and removed code duplication.
Testing
Tested on a local OPNsense instance with multiple records.