CORE-1455: Missing translation for "Content Warning" #2638

jomcarvajal · 2025-12-24T13:59:02Z

Copilot

Pull request overview

This PR adds missing translations for "Content Warning" text across English, Spanish, and Polish locales. The changes implement internationalization support by introducing a new translation key i18n:content-warning:heading:aria-label and updating the LoginGate and ContentWarning components to use translated text instead of hardcoded English strings.

Added translation key i18n:content-warning:heading:aria-label to all three language files (en, es, pl)
Updated createIntl function to support optional message overrides for testing purposes
Modified LoginGate and ContentWarning components to use the internationalization API
Updated corresponding test files to accommodate the internationalization changes

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/app/messages/en/messages.json`	Added English translation "Content Warning" for the new translation key
`src/app/messages/es/messages.json`	Added Spanish translation "Advertencia de contenido" for the new translation key
`src/app/messages/pl/messages.json`	Added Polish translation "Ostrzeżenie o treści" for the new translation key
`src/app/messages/createIntl.ts`	Enhanced to accept optional `newMessages` parameter for test message overrides
`src/app/content/components/LoginGate.tsx`	Replaced hardcoded "Content Warning" string with internationalized version using `useIntl`
`src/app/content/components/ContentWarning.tsx`	Replaced hardcoded "Content warning" string with internationalized version using `useIntl`
`src/app/content/components/LoginGate.spec.tsx`	Updated test to mock `useIntl` and added IntlProvider setup
`src/app/content/components/ContentWarning.spec.tsx`	Updated tests to mock `useIntl` and added IntlProvider setup
`src/app/content/highlights/components/Highlights.spec.tsx`	Updated tests to use new `newMessages` parameter of `createIntl` function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-05T12:40:13Z

src/app/content/components/LoginGate.tsx

    <>
      {children}
-      <Modal heading='Content Warning'>
+      <Modal heading={intl.formatMessage({ id: 'i18n:content-warning:heading:aria-label' })}>


The Modal component's heading prop is passed to FormattedMessage which expects a translation key, not a translated string. Passing intl.formatMessage({ id: 'i18n:content-warning:heading:aria-label' }) will cause the Modal to treat the translated text as a key and attempt to translate it again. Instead, pass the translation key directly: heading='i18n:content-warning:heading:aria-label' and remove the useIntl hook usage.

Copilot · 2026-01-05T12:40:14Z

src/app/content/components/LoginGate.tsx

 import { useSelector } from 'react-redux';
 import styled from 'styled-components/macro';
 import ModalWithScrollLock from '../../components/Modal';
+import { useIntl } from 'react-intl';


The useIntl import is no longer needed since the Modal component expects the translation key directly, not a pre-translated string. Remove this import.

Copilot · 2026-01-05T12:40:14Z

src/app/content/components/LoginGate.tsx

  book,
  children,
 }: React.PropsWithChildren<{ book: Book }>) {
+  const intl = useIntl();


The intl variable initialized with useIntl() is no longer needed since the Modal component expects the translation key directly. Remove this line.

Copilot · 2026-01-05T12:40:14Z

src/app/messages/createIntl.ts

 }

-export default memoize(async(loc: string) => {
+export default memoize(async(loc: string, newMessages?: Record<string, string>) => {


The memoize function from lodash/fp only uses the first argument as the cache key by default. This means calls like createIntl('en') and createIntl('en', { 'key': 'value' }) will return the same cached intl instance, ignoring the newMessages parameter on subsequent calls. If newMessages is intended to be different across calls with the same locale, consider using a custom resolver for memoization or not memoizing when newMessages is provided.

newMessages are only meant for tests, right? Maybe call them testMessages or testOverrides.

You can use the memoize function from @openstax/ts-utils to avoid the quirk of lodash's only caching based on the first argument.

Copilot · 2026-01-05T12:40:15Z

src/app/content/components/LoginGate.spec.tsx

+jest.mock('react-intl', () => ({
+  ...jest.requireActual('react-intl'),
+  useIntl: () => ({
+    formatMessage: ({ id }: any) => id,
+  }),
+}));


The mock for useIntl makes the actual createIntl and RawIntlProvider usage in the test ineffective. Since useIntl is mocked to simply return the id, the intl instance created on line 25 is not used by the component. Consider either removing the mock to test with real translations, or removing the createIntl and RawIntlProvider setup since they're not being utilized.

I don't quite get what copilot means here but maybe it's related to what it said about the modal component in the first few comments.

Copilot · 2026-01-05T12:40:15Z

src/app/content/components/ContentWarning.spec.tsx

+jest.mock('react-intl', () => ({
+  ...jest.requireActual('react-intl'),
+  useIntl: () => ({
+    formatMessage: ({ id }: any) => id,
+  }),
+}));


The mock for useIntl makes the actual createIntl and RawIntlProvider usage in these tests ineffective. Since useIntl is mocked to simply return the id, the intl instances created in the tests are not used by the components. Consider either removing the mock to test with real translations, or removing the createIntl and RawIntlProvider setup since they're not being utilized.

Dantemss · 2026-01-05T12:49:12Z

src/app/messages/pl/messages.json

  "i18n:toolbar:textresizer:button:increase:aria-label": "Zwiększ rozmiar tekstu",
-  "i18n:toolbar:textresizer:popup:heading": "Rozmiar tekstu"
+  "i18n:toolbar:textresizer:popup:heading": "Rozmiar tekstu",
+  "i18n:content-warning:heading:aria-label": "Ostrzeżenie o treści"


This translation should probably be confirmed by our contact at Katalyst

jomcarvajal and others added 9 commits December 12, 2025 10:41

add new roles for items inside ChapterFilter

ac71a5b

Merge branch 'main' into CORE-447

abef009

Merge branch 'main' into CORE-447

2c4885d

remove roles, put fieldset in ChapterFilter

346cc66

move Fieldset to Filters

ec96486

Merge branch 'CORE-447' of github.com:openstax/rex-web into CORE-447

b0a7af2

remove unused imports

28aafb3

add intl support for ContentWarning

7b03bbd

Merge branch 'main' of github.com:openstax/rex-web into CORE-1455

4bcf996

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 13:59 Inactive

space-before-function-paren

599f02a

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 14:09 Inactive

cover LoginGate heading translation

6fb5d5a

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 14:26 Inactive

mock intl in LoginGate

57fab18

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 14:58 Inactive

space-before-function-paren

76aea21

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 15:10 Inactive

jomcarvajal added 2 commits December 24, 2025 09:38

missing translation in highlights.spec

6bd2cd9

lint

9bd9bdb

TomWoodward temporarily deployed to rex-web-core-1455-vb36xzfvxvug December 24, 2025 15:41 Inactive

jomcarvajal marked this pull request as ready for review December 24, 2025 15:54

jomcarvajal requested a review from a team as a code owner December 24, 2025 15:54

jomcarvajal requested a review from Dantemss December 24, 2025 15:54

Dantemss requested a review from Copilot January 5, 2026 12:34

Copilot started reviewing on behalf of Dantemss January 5, 2026 12:34 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

Dantemss reviewed Jan 5, 2026

View reviewed changes

Merge branch 'main' into CORE-1455

20b0cfd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CORE-1455: Missing translation for "Content Warning" #2638

CORE-1455: Missing translation for "Content Warning" #2638

Uh oh!

jomcarvajal commented Dec 24, 2025 •

edited by atlassian bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Dantemss Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Dantemss Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Dantemss Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CORE-1455: Missing translation for "Content Warning" #2638

Are you sure you want to change the base?

CORE-1455: Missing translation for "Content Warning" #2638

Uh oh!

Conversation

jomcarvajal commented Dec 24, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Dantemss Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Dantemss Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Dantemss Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jomcarvajal commented Dec 24, 2025 •

edited by atlassian bot

Loading