Skip to content

Conversation

@umohnani8
Copy link
Contributor

Fixing some of the intermittent test failures

Three fixes to address intermittent test failures in CI:

1. TestControllerEventuallyReconciles timeout issue:
   - Increased job completion timeout from 10 to 20 minutes
   - Test simulates adverse conditions (scaled down deployments)
   - Image builds can take longer in resource-constrained CI environments

2. Rate limiter exhaustion in log streaming:
   - Reduced log streaming retry interval from 2s to 5s
   - Multiple concurrent goroutines were making API calls too frequently
   - 60% reduction in API call rate prevents rate limiter exhaustion

3. HTTP/2 connection errors failing tests:
   - Made log streaming errors non-fatal (log warnings instead)
   - API server closes long-running log streams when pods terminate
   - Log collection is for debugging, not a test requirement
   - Tests now pass/fail based on actual functionality
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@umohnani8
Copy link
Contributor Author

/test e2e-gcp-op-ocl

1 similar comment
@umohnani8
Copy link
Contributor Author

/test e2e-gcp-op-ocl

@djoshy
Copy link
Contributor

djoshy commented Jan 26, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Contributor

djoshy commented Jan 26, 2026

/verified bypass

only test changes

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 26, 2026
@openshift-ci-robot
Copy link
Contributor

@djoshy: The verified label has been added.

Details

In response to this:

/verified bypass

only test changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented Jan 26, 2026

/retitle NO-ISSUE: Fix e2e ocl intermittent failures

@openshift-ci openshift-ci bot changed the title NO ISSUE: Fix e2e ocl intermittent failures NO-ISSUE: Fix e2e ocl intermittent failures Jan 26, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request explicitly references no jira issue.

Details

In response to this:

Fixing some of the intermittent test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented Jan 26, 2026

/hold

in case you want to wait for the test to finish

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026
@umohnani8
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2026

@umohnani8: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2607eb0 into openshift:main Jan 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants