MCO-2065: Move systemctl execs to dbus calls #5586
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
approved
openshift-merge-robot
removed
the
needs-rebase
pablintino
force-pushed
the
dbus
branch
2 times, most recently
from
d7e3c2a to
5fda73b
Compare
|
/test e2e-gcp-op-2of2 |
pablintino
force-pushed
the
dbus
branch
2 times, most recently
from
b8dcacc to
cfb5469
Compare
|
/retitle MCO-2065 |
openshift-ci
bot
changed the title
|
/jira refresh |
openshift-ci-robot
removed
the
jira/valid-reference
|
@pablintino: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle MCO-2065: Move systemctl execs to dbus calls |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-2065 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test verify |
Replace direct systemctl exec calls with a systemd abstraction layer that uses the coreos/go-systemd library. The new SystemdManager factory pattern improves performance, maintainability, and testing by introducing easily mockable interfaces and enabling connection reuse. There are two ways of using the new interfaces: - DoConnection() for single operations with automatic cleanup - NewConnection() for batching multiple operations on one connection Signed-off-by: Pablo Rodriguez Nava <[email protected]>
|
/retest-required |
1 similar comment
|
/retest-required |
|
@pablintino: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // NormalizeSystemdUnitNames ensures unit names have valid systemd suffixes. | ||
| // D-Bus requires the full unit name (e.g., "crio.service") while systemctl | ||
| // accepts short names (e.g., "crio"). This function adds ".service" if no | ||
| // recognized suffix is present. | ||
| // | ||
| // Valid systemd unit suffixes are: | ||
| // | ||
| // .service, .socket, .device, .mount, .automount, .swap, | ||
| // .target, .path, .timer, .slice, .scope |
There was a problem hiding this comment.
Thanks for adding this comment. I was curious about the change in the CRIOServiceName constant.
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
Changes look fair to me & tests are passing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
- What I did
Replace direct systemctl exec calls with a systemd abstraction layer that uses the coreos/go-systemd library. The new SystemdManager factory pattern improves performance, maintainability, and testing by introducing easily mockable interfaces and enabling connection reuse.
- How to verify it
TBD
- Description for the changelog
Migrated systemd interactions from systemctl subprocesses to native DBus calls.