OCPBUGS-58023: Prevent unnecessary systemd unit disable #5582
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
approved
update: Only write added or updated systemd units on_disk_validation: Check if systemd units in config enabled correctly (cherry picked from commit 4512ec4)
isabella-janssen
force-pushed
the
ocpbugs-58023
branch
from
0e68ccf to
cd34c6d
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-serial-2of2 |
|
@isabella-janssen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/443c1420-f62b-11f0-9af4-102648097252-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-serial-1of2 openshift/origin#30705 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4ef340-f656-11f0-9d8c-addd25b6ef13-0 |
isabella-janssen
force-pushed
the
ocpbugs-58023
branch
from
cd34c6d to
b03faf5
Compare
isabella-janssen
changed the title
openshift-ci-robot
added
the
jira/severity-important
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-58023, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold This should merge after openshift/origin#30705. |
openshift-ci
bot
added
the
do-not-merge/hold
…sitions through 'Unknown' state
|
/payload-job-with-prs 4.22 nightly blocking openshift/origin#30705 |
|
@isabella-janssen: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get additional pr info from string: nightly: string: nightly doesn't match expected format: org/repo#number
Please contact an administrator to resolve this issue. |
|
/payload-job-with-pr 4.22 nightly blocking openshift/origin#30705 |
|
/retest-required |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b1046fe0-f7d8-11f0-8ffd-5dafc794a7fb-0 |
openshift-ci-robot
added
the
verified
|
@pablintino: This PR has been marked as verified by DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-e2e-azure-ovn-upgrade periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6 Double checking that these failures were flakes. |
|
@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80950630-f869-11f0-8c09-9a6979317915-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/55e3d380-f87d-11f0-8d3c-dc6eead53ca9-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1adb7230-fab1-11f0-8fbf-d089061d748a-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-2of2 |
|
@isabella-janssen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d428520-fac7-11f0-919f-0736acd24e91-0 |
|
/override ci/prow/e2e-gcp-op-ocl This test is newly required, but flaking for unrelated reasons. |
|
@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/e2e-gcp-op-ocl DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold The latest run of payload tests for this PR looked good, so hopefully this fix sticks this time 🤞 |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@isabella-janssen: Jira Issue OCPBUGS-58023: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-58023 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.21,release-4.20,release-4.19,release-4.18,release-4.17 |
|
@isabella-janssen: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.21 release-4.20 release-4.19 release-4.18 release-4.17 |
|
@isabella-janssen: new pull request created: #5607 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Closes: OCPBUGS-58023
- What I did
This adds back the work introduced in #5527 then reverted in #5553. It depends on regression test improvemnts in openshift/origin#30705 to prevent future regressions.
This takes inspiration from the proposed fix for OCPBUGS-58023 in #5225 and updates some of the changes to be clearer and more maintainable per review suggestions. It includes cherry-picks of the following two commits
and some cleanup.
- How to verify it
OCPBUGS-58023: See #5148 (comment) for previous verification steps.
TRT-2232: Payload tests previously impacted by this bug fix should pass.
- Description for the changelog
OCPBUGS-58023: Prevent unnecessary systemd unit disable