When processing inherited ARGs, expand their values #318
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This should fix containers/buildah#6648. |
| thisStageArgs := slices.Clone(inheritedArgs) | ||
| filteredUserArgs := make(map[string]string) | ||
| for k, v := range b.UserArgs { | ||
| for _, a := range b.GlobalAllowedArgs { |
There was a problem hiding this comment.
Not for this PR, but would it be possible to change GlobalAllowedArgs to a map to improve search efficiency? It looks like we do this loop in at least one other spot.
There was a problem hiding this comment.
It's not used by buildah or podman, but it is part of the exported API, which at this point I'd like to avoid breaking here.
|
Build seems to be failing, some kind of Docker version unhappiness? |
I expect that to be sorted by #317 and rebasing on top of it. |
Perform argument expansion when stuffing ARG values from a base stage into a new one. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Perform argument expansion when stuffing ARG values from a base stage into a new one.