Platform upgrade to new ESP32 API #69
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@copilot this is stale but needs revived. Fix the merge conflicts, pull in the latest platform in the spirit of this original PR, then after going through and fixing make sure it builds properly with the platformIO CLI |
4 tasks
|
@zjwhitehead I've opened a new pull request, #88, to work on those changes. Once the pull request is ready, I'll request review from you. |
Refactor buzzer and vibration motor initialization to use the new ledcAttach API from Arduino-ESP32 3.x. Update BLE characteristic callbacks to use String instead of std::string for compatibility. Improve ESC initialization by deferring throttle setup until after the first CAN process and add a readiness check. Update watchdog initialization to use the new esp_task_wdt_init config structure. Minor fix to pin initialization order in setup.
# Conflicts: # src/sp140/vibration_pwm.cpp
Co-authored-by: zjwhitehead <4623792+zjwhitehead@users.noreply.github.com>
Introduces a .tool-versions file specifying Python 3.11.9 for environment consistency. Also adds an extern declaration for HardwareConfig board_config in vibration_pwm.cpp to resolve linkage or visibility issues.
zjwhitehead
force-pushed
the
platform-upgrade
branch
from
f1ee0f3 to
60db71d
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses this community-maintained, up-to-date fork of the platform due to official PIO support from Espresiff being dropped.
https://github.com/pioarduino/platform-espressif32
More detailed changes can be found in the parent repos like https://github.com/espressif/arduino-esp32/releases/tag/3.3.0
Copilot Summary:
Hardware API Modernization:
src/sp140/vibration_pwm.cppandsrc/sp140/buzzer.cppto use the Arduino-ESP32 3.xledcAttachAPI, replacing legacy channel-based calls with pin-based control viaboard_config. This improves compatibility and simplifies hardware initialization and usage.Platform and Build Configuration Updates:
platformio.inito use the latest Arduino-ESP32 platform from thepioarduinoGitHub repository and added a flag for USB serial compatibility..tool-versionsand updated GitHub Actions workflow to use Python 3.11 for all jobs, ensuring consistency in CI environments.Safety and Reliability Enhancements:
src/sp140/esc.cppby deferring throttle commands until after CAN adapter is ready, adding readiness checks, and preventing null pointer access.src/sp140/sp140.inofor safer initialization using the new ESP-IDF API, handling error conditions more robustly.Development Environment Improvements:
pioarduino.pioarduino-ideextension to VSCode recommendations for a smoother developer experience.