Add validation to prevent steadystate solver with multiple sediment fractions#258
Merged
Sierd merged 2 commits intoSierd-patch-1from Nov 4, 2025
Merged
Add validation to prevent steadystate solver with multiple sediment fractions#258Sierd merged 2 commits intoSierd-patch-1from
Sierd merged 2 commits intoSierd-patch-1from
Conversation
…ractions Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor sweep functions and remove unused code
Add validation to prevent steadystate solver with multiple sediment fractions
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The steadystate solver is not compatible with multiple sediment fractions, but this constraint was not enforced, allowing invalid configurations to run.
Changes
check_configuration()to detect and reject steadystate solvers (steadystate,steadystatepieter) whengrain_sizecontains multiple fractionstrunk,pieter)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.