chore: upgrade helm chart dependencies#29
Conversation
📝 WalkthroughWalkthroughBumps Helm chart versions and upgrades dependencies across observability charts: fluent-bit, kube-prometheus-stack, and opentelemetry-collector versions updated in five Chart.yaml files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@observability-metrics-prometheus/helm/Chart.yaml`:
- Line 20: The bump of kube-prometheus-stack to version 81.6.3 requires CRD
upgrades but values.yaml currently leaves crds.enabled set without enabling
automatic upgrades; update observability-metrics-prometheus/helm/values.yaml to
either set crds.upgradeJob.enabled: true (to run the upstream CRD upgrade job
provided since v68.4.0) or, if you want manual control, add explicit release
notes documenting the manual CRD apply steps (e.g., pull and kubectl apply the
chart CRDs before upgrade) so upgrades don’t keep stale CRDs; reference the
chart version 81.6.3, kube-prometheus-stack, and the crds.enabled /
crds.upgradeJob.enabled keys when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9b3a5ecc-e611-4516-84ea-99b88d06d3f5
⛔ Files ignored due to path filters (5)
observability-logs-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-logs-opensearch/helm/Chart.lockis excluded by!**/*.lockobservability-metrics-prometheus/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-opensearch/helm/Chart.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
observability-logs-openobserve/helm/Chart.yamlobservability-logs-opensearch/helm/Chart.yamlobservability-metrics-prometheus/helm/Chart.yamlobservability-tracing-openobserve/helm/Chart.yamlobservability-tracing-opensearch/helm/Chart.yaml
| - name: kube-prometheus-stack | ||
| repository: https://prometheus-community.github.io/helm-charts | ||
| version: 78.3.0 | ||
| version: 81.6.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Dependency bump in Chart.yaml:"
sed -n '17,22p' observability-metrics-prometheus/helm/Chart.yaml
echo
echo "CRD settings in local values.yaml:"
sed -n '1,40p' observability-metrics-prometheus/helm/values.yaml | rg -n -C2 'crds:|upgradeJob|enabled:'
echo
echo "Upstream upgrade notes for 79.x->80.x and 80.x->81.x:"
curl -fsSL https://raw.githubusercontent.com/prometheus-community/helm-charts/main/charts/kube-prometheus-stack/UPGRADE.md | sed -n '1,8p'Repository: openchoreo/community-modules
Length of output: 1125
Add CRD upgrade handling for the kube-prometheus-stack version bump.
Upgrading to 81.6.3 requires CRD updates, but observability-metrics-prometheus/helm/values.yaml enables crds.enabled without configuring crds.upgradeJob.enabled. This means existing installations will upgrade with stale CRDs unless you either enable the automatic upgrade job or document the manual CRD apply step in release notes.
The upstream chart documentation supports automatic CRD upgrades via crds.upgradeJob.enabled since v68.4.0. Enable it or document the manual CRD update commands as part of the upgrade runbook.
Suggested change
# observability-metrics-prometheus/helm/values.yaml
crds:
enabled: true
+ upgradeJob:
+ enabled: trueOr add upstream CRD update commands to release notes if you prefer manual control.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@observability-metrics-prometheus/helm/Chart.yaml` at line 20, The bump of
kube-prometheus-stack to version 81.6.3 requires CRD upgrades but values.yaml
currently leaves crds.enabled set without enabling automatic upgrades; update
observability-metrics-prometheus/helm/values.yaml to either set
crds.upgradeJob.enabled: true (to run the upstream CRD upgrade job provided
since v68.4.0) or, if you want manual control, add explicit release notes
documenting the manual CRD apply steps (e.g., pull and kubectl apply the chart
CRDs before upgrade) so upgrades don’t keep stale CRDs; reference the chart
version 81.6.3, kube-prometheus-stack, and the crds.enabled /
crds.upgradeJob.enabled keys when making the change.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@observability-metrics-prometheus/helm/Chart.yaml`:
- Around line 8-9: The Chart.yaml has mismatched release fields: update the
appVersion value to match the chart version (change appVersion from "0.2.3" to
"0.2.4") so Chart.yaml's appVersion and version are consistent; modify the
appVersion field in Chart.yaml (the appVersion key) accordingly and keep them
synced for future bumps.
In `@observability-tracing-opensearch/helm/Chart.yaml`:
- Around line 8-9: The Chart.yaml currently has version: 0.3.4 but appVersion:
"0.3.3", causing metadata mismatch; update the appVersion field to "0.3.4" so
appVersion matches the chart version (edit the Chart.yaml keys 'version' and
'appVersion' to keep them consistent).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ade248a1-95cd-4bdc-a44f-c22f7f3415fe
⛔ Files ignored due to path filters (5)
observability-logs-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-logs-opensearch/helm/Chart.lockis excluded by!**/*.lockobservability-metrics-prometheus/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-opensearch/helm/Chart.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
observability-logs-openobserve/helm/Chart.yamlobservability-logs-opensearch/helm/Chart.yamlobservability-metrics-prometheus/helm/Chart.yamlobservability-tracing-openobserve/helm/Chart.yamlobservability-tracing-opensearch/helm/Chart.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
- observability-logs-opensearch/helm/Chart.yaml
- observability-tracing-openobserve/helm/Chart.yaml
- observability-logs-openobserve/helm/Chart.yaml
| version: 0.2.4 | ||
| appVersion: "0.2.3" |
There was a problem hiding this comment.
Bump appVersion with the chart release.
Line 8 updates the chart to 0.2.4, but Line 9 still reports 0.2.3. That leaves stale release metadata in the packaged chart.
Suggested change
version: 0.2.4
-appVersion: "0.2.3"
+appVersion: "0.2.4"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| version: 0.2.4 | |
| appVersion: "0.2.3" | |
| version: 0.2.4 | |
| appVersion: "0.2.4" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@observability-metrics-prometheus/helm/Chart.yaml` around lines 8 - 9, The
Chart.yaml has mismatched release fields: update the appVersion value to match
the chart version (change appVersion from "0.2.3" to "0.2.4") so Chart.yaml's
appVersion and version are consistent; modify the appVersion field in Chart.yaml
(the appVersion key) accordingly and keep them synced for future bumps.
| version: 0.3.4 | ||
| appVersion: "0.3.3" |
There was a problem hiding this comment.
Update appVersion to match this release.
Line 8 bumps the chart to 0.3.4, but Line 9 still advertises 0.3.3. That will publish outdated chart metadata.
Suggested change
version: 0.3.4
-appVersion: "0.3.3"
+appVersion: "0.3.4"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| version: 0.3.4 | |
| appVersion: "0.3.3" | |
| version: 0.3.4 | |
| appVersion: "0.3.4" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@observability-tracing-opensearch/helm/Chart.yaml` around lines 8 - 9, The
Chart.yaml currently has version: 0.3.4 but appVersion: "0.3.3", causing
metadata mismatch; update the appVersion field to "0.3.4" so appVersion matches
the chart version (edit the Chart.yaml keys 'version' and 'appVersion' to keep
them consistent).
Signed-off-by: Ketharan <ketharan.mail@gmail.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
observability-metrics-prometheus/helm/Chart.yaml (1)
17-20:⚠️ Potential issue | 🟠 MajorAdd an explicit CRD upgrade path for this
kube-prometheus-stackjump.Upstream calls out that Helm v3 does not update these CRDs automatically, both
79.x -> 80.xand80.x -> 81.xrequire CRD updates, and the chart exposescrds.upgradeJob.enabledfor that path while keeping it off by default. Please verify this module either enables the upgrade job inobservability-metrics-prometheus/helm/values.yamlor documents the manual CRD apply step for existing installs. (raw.githubusercontent.com)#!/bin/bash set -euo pipefail echo "Dependency bump in Chart.yaml:" sed -n '17,22p' observability-metrics-prometheus/helm/Chart.yaml echo echo "CRD-related settings in local values.yaml:" sed -n '1,80p' observability-metrics-prometheus/helm/values.yaml | \ rg -n -C2 '^\s*crds:|^\s*upgradeJob:|^\s*enabled:' echo echo "Any local upgrade notes mentioning CRD handling:" rg -n -C2 'crds\.upgradeJob|monitoring\.coreos\.com_(alertmanagerconfigs|servicemonitors|prometheusrules)|kube-prometheus-stack' \ observability-metrics-prometheus README.md || true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@observability-metrics-prometheus/helm/Chart.yaml` around lines 17 - 20, The Chart.yaml bumps kube-prometheus-stack to 81.6.3 but does not provide an explicit CRD upgrade path; update observability-metrics-prometheus/helm/values.yaml to either enable the chart's CRD upgrade job by setting crds.upgradeJob.enabled: true for upgrades from 79.x/80.x -> 81.x or add a clear README entry documenting the manual kubectl apply steps for the CRDs (include the exact upstream CRD manifest URL and the command) and mention the kube-prometheus-stack semantic requirement so operators know to run the upgrade job or manual apply before upgrading the chart.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@observability-metrics-prometheus/helm/Chart.yaml`:
- Around line 17-20: The Chart.yaml bumps kube-prometheus-stack to 81.6.3 but
does not provide an explicit CRD upgrade path; update
observability-metrics-prometheus/helm/values.yaml to either enable the chart's
CRD upgrade job by setting crds.upgradeJob.enabled: true for upgrades from
79.x/80.x -> 81.x or add a clear README entry documenting the manual kubectl
apply steps for the CRDs (include the exact upstream CRD manifest URL and the
command) and mention the kube-prometheus-stack semantic requirement so operators
know to run the upgrade job or manual apply before upgrading the chart.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f2f48e34-1a26-4ee0-8b4b-6c66b5d51e20
⛔ Files ignored due to path filters (5)
observability-logs-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-logs-opensearch/helm/Chart.lockis excluded by!**/*.lockobservability-metrics-prometheus/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-openobserve/helm/Chart.lockis excluded by!**/*.lockobservability-tracing-opensearch/helm/Chart.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
observability-logs-openobserve/helm/Chart.yamlobservability-logs-opensearch/helm/Chart.yamlobservability-metrics-prometheus/helm/Chart.yamlobservability-tracing-openobserve/helm/Chart.yamlobservability-tracing-opensearch/helm/Chart.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- observability-logs-opensearch/helm/Chart.yaml
| type: application | ||
| version: 0.2.1 | ||
| version: 0.2.2 | ||
| appVersion: "0.2.1" |
There was a problem hiding this comment.
Please bump the appversion too in all the places where you are bumping the version
nilushancosta
left a comment
nilushancosta
left a comment
There was a problem hiding this comment.
Also update the versions in the READMEs as well
2 participants
Upgrades helm chart dependencies across observability modules:
Summary by CodeRabbit