Skip to content

fix: activity type selection for Email when editing #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymoususer72041 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: activity type selection for Email when editing #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/activity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function Activity_fillTypeSelect(selectList, selectedText)
/* Email option. */
optionElements[4] = document.createElement('option');
optionElements[4].value = ACTIVITY_EMAIL;
optionElements[4].appendChild(document.createTextNode('E-Mail'));
optionElements[4].appendChild(document.createTextNode('Email'));

/* Meeting option. */
optionElements[5] = document.createElement('option');
Expand Down Expand Up @@ -95,7 +95,7 @@ function Activity_fillTypeSelect(selectList, selectedText)
{
optionElements[3].setAttribute('selected', 'selected');
}
else if (selectedText == 'E-Mail')
else if (selectedText == 'Email')
{
optionElements[4].setAttribute('selected', 'selected');
}
Expand Down
2 changes: 1 addition & 1 deletion modules/candidates/AddActivityChangeStatusModal.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
<option value="<?php echo(ACTIVITY_CALL_TALKED); ?>">Call (Talked)</option>
<option value="<?php echo(ACTIVITY_CALL_LVM); ?>">Call (LVM)</option>
<option value="<?php echo(ACTIVITY_CALL_MISSED); ?>">Call (Missed)</option>
<option value="<?php echo(ACTIVITY_EMAIL); ?>">E-Mail</option>
<option value="<?php echo(ACTIVITY_EMAIL); ?>">Email</option>
<option value="<?php echo(ACTIVITY_MEETING); ?>">Meeting</option>
<option value="<?php echo(ACTIVITY_OTHER); ?>">Other</option>
</select><br />
Expand Down
2 changes: 1 addition & 1 deletion modules/contacts/AddActivityScheduleEventModal.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<option value="<?php echo(ACTIVITY_CALL_TALKED); ?>">Call (Talked)</option>
<option value="<?php echo(ACTIVITY_CALL_LVM); ?>">Call (LVM)</option>
<option value="<?php echo(ACTIVITY_CALL_MISSED); ?>">Call (Missed)</option>
<option value="<?php echo(ACTIVITY_EMAIL); ?>">E-Mail</option>
<option value="<?php echo(ACTIVITY_EMAIL); ?>">Email</option>
<option value="<?php echo(ACTIVITY_MEETING); ?>">Meeting</option>
<option value="<?php echo(ACTIVITY_OTHER); ?>">Other</option>
</select><br />
Expand Down
Loading