avoid calling glfwTerminate() inside callback#603
Open
samarth-robo wants to merge 1 commit intoopenai:masterfrom
Open
avoid calling glfwTerminate() inside callback#603samarth-robo wants to merge 1 commit intoopenai:masterfrom
samarth-robo wants to merge 1 commit intoopenai:masterfrom
Conversation
[GLFW guidelines](https://www.glfw.org/docs/3.3/intro_guide.html#reentrancy) say `glfwTerminate()` should not be called inside an event callback, since it is not reentrant. This fixes segfault when closing the `MjViewer` window by pressing ESC.
samarth-robo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLFW guidelines say
glfwTerminate()should not be called inside an event callback, since it is not reentrant. This fixes segfault when closing theMjViewerwindow by pressing ESC.