Colors theme: fix chargepoint display#3157
Merged
LKuemmel merged 1 commit intoopenWB:masterfrom Feb 24, 2026
Merged
Conversation
Collaborator
cshagen
commented
Feb 23, 2026
cshagen
commented
- Korrektur Ladepunkt
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the chargepoint display logic where chargepoint 0 would be incorrectly rejected due to a falsy value check. The bug prevented messages for chargepoint 0 from being processed since the condition if (index && !(index in chargePoints)) would evaluate the numeric index 0 as falsy.
Changes:
- Fixed the index validation condition to use explicit undefined check instead of truthy check, allowing chargepoint 0 to be properly processed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.