Skip to content

Allow resolving from resolved schema using Manifest file.#1160

Open
jsuereth wants to merge 14 commits intoopen-telemetry:mainfrom
jsuereth:wip-resolve-using-manifest
Open

Allow resolving from resolved schema using Manifest file.#1160
jsuereth wants to merge 14 commits intoopen-telemetry:mainfrom
jsuereth:wip-resolve-using-manifest

Conversation

@jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Jan 26, 2026

Fixes #1134

Should allow specifying a schema like in OTEP 4815.

  • Can specify a manifest instead of a directory, e.g. http://my-schema.org/manifest/1.0.0
  • Will use the resolved_schema_url, if available, on that manifest to resolve schema instead of grabbing .yaml files from the directory.
  • Allow relative URLs for resolved_schema_url, although this needs to be tested a bit.

Thing not working yet:

  • Extending groups from V2
  • Actually using manifest.yaml vs. registry_manifest.yaml as per OTEP 4815.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 84.83607% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.4%. Comparing base (a74480e) to head (a18e5a6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolver/src/dependency.rs 89.3% 17 Missing ⚠️
crates/weaver_resolver/src/loader.rs 70.0% 9 Missing ⚠️
crates/weaver_common/src/vdir.rs 46.1% 7 Missing ⚠️
crates/weaver_common/src/lib.rs 75.0% 2 Missing ⚠️
crates/weaver_resolver/src/attribute.rs 94.7% 1 Missing ⚠️
crates/weaver_semconv/src/registry_repo.rs 93.3% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1160     +/-   ##
=======================================
+ Coverage   80.1%   80.4%   +0.3%     
=======================================
  Files        108     108             
  Lines       8440    8661    +221     
=======================================
+ Hits        6763    6967    +204     
- Misses      1677    1694     +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuereth jsuereth marked this pull request as ready for review January 28, 2026 14:13
@jsuereth jsuereth requested a review from a team as a code owner January 28, 2026 14:13
@jsuereth jsuereth changed the title [DRAFT] Allow resolving from resolved schema using Manifest file. Allow resolving from resolved schema using Manifest file. Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support resolved schema as input

1 participant