Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Feb 3, 2026

Fixes #3840

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff marked this pull request as ready for review February 3, 2026 08:37
@marcalff marcalff requested a review from a team as a code owner February 3, 2026 08:37
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.97%. Comparing base (437ad43) to head (54974c5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...metrics/export/periodic_exporting_metric_reader.cc 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
+ Coverage   89.96%   89.97%   +0.02%     
==========================================
  Files         225      225              
  Lines        7169     7168       -1     
==========================================
  Hits         6449     6449              
+ Misses        720      719       -1     
Files with missing lines Coverage Δ
...metrics/export/periodic_exporting_metric_reader.cc 77.42% <50.00%> (+0.83%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 578c101 into open-telemetry:main Feb 4, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDK] Invalid thread instrumentation in PeriodicExportingMetricReader

2 participants