Attempt 1: replacing DLExpressivity by DLExpressivityChecker#1207
Draft
Attempt 1: replacing DLExpressivity by DLExpressivityChecker#1207
Conversation
This is try to sort out the problem that the previous solution shows gibberish expressivity levels: "expressivity": "RRESTRCUCINTUNIVRESTREROIF(D)". But it does not work..
|
A workaround might be using Collection<Languages> languages = checker.expressibleInLanguages();
if (languages == null || languages.isEmpty()) {
System.err.println("No language found");
} else {
Languages[] array = languages.toArray(new Languages[languages.size()]);
Arrays.sort(array);
System.err.println(array[0]);
} |
…culation @ckindermann has suggested this approach. I relies on the fact that expressibleInLanguages() give the set of all languages, and the sorting sorts by whether one is contained in another.
|
Your commit message is not correct:
However, there may be multiple languages satisfying these criteria. In this case, sorting just makes the output deterministic. |
Contributor
Author
|
Thank you @ckindermann - I will make sure to rectify the commit message when its time to create a squash merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is try to sort out the problem that the previous solution shows gibberish expressivity levels:
"expressivity": "RRESTRCUCINTUNIVRESTREROIF(D)". But it does not work..
Resolves [#ISSUE, resolves #ISSUE]
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updated[DESCRIPTION, mentioning relevant #ISSUE]