chore: release v0.1.5

[onsails]

🤖 New release

• ccsync-core: 0.1.4 -> 0.1.5 (✓ API compatible changes)
• ccsync: 0.1.4 -> 0.1.5

Changelog

ccsync-core

0.1.5 - 2025-10-29

Fixed

• apply pattern matching to relative paths instead of absolute paths

Other

• standardize config file naming to use .toml extension
• (deps) bump the prod-deps group with 4 updates (#13)

ccsync

0.1.5 - 2025-10-29

Other

• update Cargo.toml dependencies

---

This PR was generated with release-plz.

[claude]

Pull Request Review: Release v0.1.5

Summary

✅ APPROVE with one required fix

This is a well-structured release PR generated by release-plz that properly bumps versions from 0.1.4 to 0.1.5. The patch version bump is appropriate for dependency updates only.

---

✅ Strengths

1. Correct Semantic Versioning: Patch bump (0.1.4 → 0.1.5) is appropriate since only production dependencies were updated in PR chore(deps): bump the prod-deps group with 4 updates #13, with no source code changes.

2. Version Consistency: All version references are properly synchronized:

   • Workspace version updated in root Cargo.toml
   • Both Cargo.lock entries updated
   • Internal dependency ccsync-core version updated in crates/ccsync/Cargo.toml

3. Proper Dependency Management:

   • Follows workspace inheritance pattern (version.workspace = true)
   • Path dependency version properly updated
   • External dependency updates are all backward-compatible

4. Changelog Quality:

   • Follows Keep a Changelog format
   • Includes GitHub compare links
   • References related PR chore(deps): bump the prod-deps group with 4 updates #13
   • Dates are current (2025-10-29)

---

⚠️ Required Fix

README.md Version Reference (line 18)
The installation command still references the old version:

curl https://i.jpillora.com/onsails/[email protected]! | bash

Action Required: Update to ccsync-v0.1.5 before merging.

---

📋 Pre-Merge Checklist

Per CLAUDE.md requirements, verify:

• cargo clippy --workspace -- -D warnings passes
• cargo test --workspace passes
• README.md updated to reference v0.1.5
• Git tags will be created by release workflow

---

📊 Change Analysis

Files Modified: 6

• Version Updates: Cargo.toml, Cargo.lock, crates/ccsync/Cargo.toml
• Documentation: crates/ccsync/CHANGELOG.md, crates/ccsync-core/CHANGELOG.md

Dependency Updates from PR #13:

• dialoguer: 0.11.0 → 0.12.0
• ctrlc: 3.4.7 → 3.5.1
• assert_cmd: 2.0.17 → 2.1.0 (dev)
• tempfile: 3.17.1 → 3.23.0 (dev)

All follow semantic versioning with no breaking changes.

---

🎯 Risk Assessment

Risk Level: LOW

• No source code changes
• Only dependency updates (maintenance release)
• All version references are consistent
• Follows workspace best practices

---

💡 Optional Improvements

1. Consider adding rust-version to workspace Cargo.toml to document MSRV
2. The ccsync/CHANGELOG.md entry could reference PR chore(deps): bump the prod-deps group with 4 updates #13 for consistency with ccsync-core

---

Generated via automated code review following project standards

[claude]

Code Review: PR #14 - Release v0.1.5

Overview

This release PR includes version bumps to v0.1.5, changelog updates, dependency updates from PR #13, and a key bug fix: Pattern matching now applies to relative paths instead of absolute paths.

---

✅ Strengths

1. Well-Structured Architecture

• Clean workspace with proper separation between ccsync-core (library) and ccsync (CLI binary)
• Modular organization with clear separation of concerns
• Proper use of Rust 2024 edition

2. Excellent Error Handling

• Consistent use of anyhow::Result with contextual error messages
• Proper error propagation throughout
• Good use of .with_context() for error chain building
• No error swallowing patterns detected

3. Key Bug Fix - Pattern Matching ⭐

The core fix in orchestrator.rs:86-99 correctly applies pattern matching to relative paths:

• Allows gitignore-style patterns like agents/git-* to work as expected
• Clean implementation with proper error handling
• Well-tested with integration test coverage
• No breaking changes to public API

4. Strong Safety Features

• unsafe_code = "forbid" enforced in workspace lints
• Security-conscious symlink handling
• Proper use of #[must_use] attributes

5. Comprehensive Testing

• Good unit and integration test coverage
• Uses tempfile for isolated test environments
• Pattern fix includes dedicated test case

---

⚠️ Minor Suggestions for Future PRs

1. Error Storage (Low Priority)

In orchestrator.rs:111-114, errors are converted to String, losing error chains:

result.errors.push(e.to_string());

Consider preserving full error context:

result.errors.push(format!("{e:?}"));

2. Environment Variables (Best Practice)

Consider using the existing dirs crate dependency instead of manual HOME/USERPROFILE reading:

use dirs::home_dir;
let home = home_dir().context("Failed to determine home directory")?;

---

🎯 Security Assessment

✅ All Clear

• Proper symlink handling with symlink_metadata()
• Path traversal protection via strip_prefix() validation
• No unsafe code
• Reputable dependencies

---

📊 Quality Ratings

• Code Quality: ⭐⭐⭐⭐⭐ (5/5)
• Test Coverage: ⭐⭐⭐⭐⭐ (5/5)
• Security: ⭐⭐⭐⭐⭐ (5/5)
• Documentation: ⭐⭐⭐⭐☆ (4/5)
• Best Practices: ⭐⭐⭐⭐⭐ (5/5)

Overall: ⭐⭐⭐⭐⭐ (5/5)

---

✅ Recommendation: APPROVE

This is a clean release with a well-implemented bug fix. The pattern matching fix addresses a real issue and includes proper test coverage. No blocking issues identified.

Pre-merge Checklist:

• Ensure all CI checks pass
• Verify cargo clippy --workspace -- -D warnings passes
• Verify cargo test --workspace passes

---

Great work on the pattern matching fix! 🎉

[claude]

PR Review: Release v0.1.5

Summary

This is a release PR generated by release-plz, bumping the version from 0.1.4 to 0.1.5. The PR includes version updates, dependency bumps, and changelog entries for two key changes.

---

✅ Positive Findings

1. Semantic Versioning: CORRECT

The patch version bump (0.1.4 → 0.1.5) is semantically appropriate for:

• Bug fix: pattern matching on relative paths
• Internal refactoring
• Dependency updates

2. Changelog Quality: GOOD

Both changelogs follow Keep a Changelog format correctly:

• Clear categorization (Fixed, Other)
• Proper version links
• Concise but descriptive entries
• Links to related PRs (chore(deps): bump the prod-deps group with 4 updates #13)

3. Dependency Management: CORRECT

All version references are properly synchronized:

• Cargo.lock: Both crates updated to 0.1.5 ✓
• Cargo.toml (workspace): Version bumped to 0.1.5 ✓
• crates/ccsync/Cargo.toml: Dependency on ccsync-core updated to 0.1.5 ✓

---

⚠️ Critical Concern: Breaking Change Not Clearly Communicated

Config File Naming Change

The changelog mentions "standardize config file naming to use .toml extension" under "Other", but this is actually a BREAKING CHANGE for existing users.

Impact:

• Old config files: .ccsync and .ccsync.local (without extension)
• New config files: .ccsync.toml and .ccsync.local.toml (with extension)
• Users' existing config files will NOT be recognized after upgrading

The code in config/discovery.rs:56-57 only looks for files with the .toml extension:

let local = Self::find_file(".ccsync.local.toml");
let project = Self::find_file(".ccsync.toml");

Recommendations:

Option 1: Add Migration Documentation (Quick Fix)
Add a prominent section to the changelog:

### ⚠️ Breaking Changes

- **Config file naming**: Config files must now use the `.toml` extension
  - Rename `.ccsync` → `.ccsync.toml`
  - Rename `.ccsync.local` → `.ccsync.local.toml`
  - Migration command: `mv .ccsync .ccsync.toml && mv .ccsync.local .ccsync.local.toml` (if files exist)

Option 2: Add Backward Compatibility (Better UX)
Modify config/discovery.rs to:

1. Check for both old and new filenames
2. Emit a deprecation warning if old filenames are found
3. This would justify a 0.2.0 minor version bump instead

Option 3: Consider 0.2.0 Release
If this change is considered breaking enough, consider bumping to 0.2.0 to signal to users that they should pay attention to the release notes.

---

📋 Additional Observations

Code Quality

• ✅ Follows Rust best practices
• ✅ Uses proper error handling
• ✅ Security-conscious (symlink checks in config discovery)
• ✅ Well-documented code with comments

Testing

• ℹ️ Cannot verify CI status from this environment
• ℹ️ Existing tests should cover version bumps
• ⚠️ No migration tests for config file naming change

Documentation

• ✅ README already documents the new .toml extension format
• ✅ Code comments are clear and helpful
• ⚠️ No migration guide for users upgrading from old config format

Performance

• ✅ No performance concerns with these changes
• ✅ Pattern matching fix should improve correctness without performance impact

Security

• ✅ No security concerns
• ✅ Config discovery properly uses symlink_metadata() to avoid following symlinks

---

🎯 Recommendation

CONDITIONAL APPROVAL ⚠️

The release is technically correct, but the user experience could be significantly improved by:

1. Minimum requirement: Add a "Breaking Changes" or "Migration" section to the CHANGELOG documenting the config file rename requirement
2. Better: Add backward compatibility to check for both old and new config file names with deprecation warnings
3. Best: If choosing backward compatibility, consider a 0.2.0 release to signal the change

Without clear migration documentation, users will be confused when their config files stop working after upgrading.

---

📝 Checklist Status

Since I cannot run Rust tooling in this CI environment, please verify:

• cargo clippy --workspace -- -D warnings passes
• cargo test --workspace passes
• cargo fmt --all -- --check passes
• All CI checks are green

---

Overall Assessment: The code quality is excellent, dependencies are properly managed, and versioning is semantically correct. The main concern is the user-facing breaking change that needs better communication in the changelog.

Great work on the pattern matching fix! 🎉