Open
Conversation
onadata/apps/messaging/tasks.py
Outdated
| # pylint: disable=too-many-arguments,too-many-positional-arguments | ||
| @app.task(base=AutoRetryTask) | ||
| @use_master | ||
| def send_message( |
Contributor
There was a problem hiding this comment.
Let's rename this to send_message_async and create a send_message utility method in onadata.libs that contains the implementation details example
I also think it's time we rename send_message to something else since it's ambiguous to sending an email message though this is up for discussion
Member
Author
There was a problem hiding this comment.
I renamed it to send_message_async.
Maybe we can rename it to log_activity?
Base automatically changed from
revert-activity-log-folding-implementation
to
main
December 15, 2025 07:40
FrankApiyo
force-pushed
the
make-send-message-call-asynchronous
branch
from
b1019c8 to
5e115f0
Compare
FrankApiyo
force-pushed
the
make-send-message-call-asynchronous
branch
from
5e115f0 to
d7d41ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #