Skip to content

Conversation

@lostmsu
Copy link
Contributor

@lostmsu lostmsu commented Jan 27, 2026

fixes #66

@oleg-st
Copy link
Owner

oleg-st commented Jan 27, 2026

I briefly looked at DeflateStream/BrotliStream, inner Flush is done after Flush, but not after Dispose (with leaveOpen true). So it needs to be done in Flush/FlushAsync, not in FlushInternal/FlushInternalAsync.

@lostmsu
Copy link
Contributor Author

lostmsu commented Jan 27, 2026

@oleg-st I think not doing inner Flush in FlushInternal* might lead to mistakes in the future. Either these methods should be renamed or they should flush the inner stream.

@oleg-st
Copy link
Owner

oleg-st commented Jan 27, 2026

We can rename FlushInternal to WriteNothing or WriteEmpty or something like this

@lostmsu
Copy link
Contributor Author

lostmsu commented Jan 27, 2026

Doesn't it actually commit the compressor block or something like that?

@oleg-st
Copy link
Owner

oleg-st commented Jan 27, 2026

It depends on directive argument

@oleg-st
Copy link
Owner

oleg-st commented Jan 29, 2026

Added PR #68 with you as co author

@lostmsu Could you check it?

@oleg-st oleg-st closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flushing CompressionStream does not flush the underlying stream

2 participants