Stop window scrolling on touch devices when moving a piece#150
Open
Tpimp wants to merge 2 commits intooakmac:masterfrom
Open
Stop window scrolling on touch devices when moving a piece#150Tpimp wants to merge 2 commits intooakmac:masterfrom
Tpimp wants to merge 2 commits intooakmac:masterfrom
Conversation
fixed to not break scrolling on iOS devices but still prevent screen drag. Tested on Safari iOS, Android Chrome, Blackberry webkit browser.
|
Hi @Tpimp. For testing you could give a try to browserstack not real devices but can help to confirm more. |
|
Ngentot |
|
Any news on this? |
|
Hey, I had a similar problem on touch devices. Below is my solution... |
You should add a custom CSS to avoid conflicts with passive events and active events by default like touch. https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action I solve the problem with your solution but I added a custom css to my board like #myBoard { touch-action:none; } and works perfectly! I think somebody can pull a fix, it only needs 3 or 4 code lines and can be tracked and encapsulated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small patch to touchstartSquare. Should be merged upstream after more testing. I have tested on multiple mobile devices without side effect.