Open
Conversation
Contributor
|
So this already works if staging and live are on the same server; the server just ssh's into itself. The reason I kept it this way is to keep the code path pure/simple. I'll have a look at the PR tho. |
Author
|
Thanks @khalwat - the issue is that a user needs to then copy their Public Key (for the web server user) into the same users |
|
This is very useful for my setup @khalwat - is this something you are likely to merge? |
Contributor
|
I want to have a good review of it, but I'm not opposed to the idea, as long as it isn't adding an additional code path (which it doesn't appear to be). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
REMOTE_DB_USING_SSH, offer the ability to locally sync assets such as when staging/live is on the same environment (i.e. without requiring SSH) via a new flagREMOTE_ASSETS_USING_SSH