Support schema without Query type when using federation#1925
Merged
spawnia merged 6 commits intonuwave:masterfrom Aug 24, 2021
Merged
Support schema without Query type when using federation#1925spawnia merged 6 commits intonuwave:masterfrom
Query type when using federation#1925spawnia merged 6 commits intonuwave:masterfrom
Conversation
Collaborator
|
This is not that easy, see graphql/graphql-spec#631 If we make this possible, it should not be limited to Federation. We need to make sure that validation and introspection still work. |
Collaborator
Contributor
Author
|
Yes it makes sense to implement it globally but it's more complex because it needs to handle validation and introspection correctly. With this "federation only" implementation the Anyway I did some tests with apollo gateway and this implementation (only type extension and no root Query) and it seems to works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When using federation it is possible to have a schema without the
Querytype and only types extensions.With this change it is possible to omit the
QuerytypeBreaking changes
none.