Skip to content

Conversation

@bonsak
Copy link
Contributor

@bonsak bonsak commented Feb 9, 2026

This commit adds missing keys and values to the Norwegian translation
It also renames previous locale (no-NO) to nb-NO (Bokmål) to open for nn-NO (Nynorsk) translation in the feature.

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 7:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 7:02pm
npmx-lunaria Ignored Ignored Feb 10, 2026 7:02pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

This change renames the Norwegian locale entry in config/i18n.ts from code no-NO/file no-NO.json/name Norsk to nb-NO/nb-NO.json/Norsk (Bokmål) and adds a new, expanded nb-NO.json. The new locale file introduces many translation keys and objects (shortcuts, search enhancements, data_source, provenance_section, likes, size, no_dependency, privacy_policy, default_input_error, and other UI strings), plus a top-level $schema entry.

Possibly related PRs

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: adding missing translation keys to Norwegian and renaming the locale from no-NO to nb-NO (Bokmål).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines +248 to 260
"provenance_section": {
"title": "Opprinnelse",
"built_and_signed_on": "Bygget og signert på {provider}",
"view_build_summary": "Vis byggeoppsummering",
"source_commit": "Kilde-commit",
"build_file": "Byggefil",
"public_ledger": "Offentlig hovedbok",
"transparency_log_entry": "Åpenhetsloggoppføring",
"view_more_details": "Vis flere detaljer",
"error_loading": "Kunne ikke laste opprinnelsesdetaljer"
},
"provenance_section": {},
"security_downgrade": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove duplicate keys that override translations.

Line 259 and Line 1057 re‑declare provenance_section and privacy_policy. In JSON, the last key wins, so the populated translations are discarded. Please remove the empty duplicates.

🧹 Suggested fix
@@
-    "provenance_section": {},
     "security_downgrade": {},
@@
-  "privacy_policy": {
-    "cookies": {
-      "what_are": {},
-      "types": {},
-      "local_storage": {},
-      "management": {}
-    },
-    "analytics": {},
-    "authenticated": {},
-    "data_retention": {},
-    "your_rights": {},
-    "contact": {},
-    "changes": {}
-  }

Also applies to: 977-1070

🧰 Tools
🪛 Biome (2.3.14)

[error] 250-250: The key provenance_section was already declared.

This is where a duplicated key was declared again.

If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.

(lint/suspicious/noDuplicateObjectKeys)

@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 6c1083f Feb 10, 2026
17 checks passed
@bonsak bonsak deleted the Fix/update-norwegian-translation branch February 10, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants