-
-
Notifications
You must be signed in to change notification settings - Fork 232
chore: rearrange footer items #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe pull request relocates four external documentation links (docs, source, social, and chat) within the desktop footer component. These links are moved from their original position in the top-right inline footer navigation to a lower placement following the modal section. Additionally, a cursor-pointer class is added to the footer button styling to modify its cursor behaviour. The component maintains the same links and functionality whilst adjusting their visual positioning within the footer layout. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
| <button | ||
| type="button" | ||
| class="group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200" | ||
| class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200" | ||
| @click.prevent="showModal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove inline focus-visible utilities from the button.
The class still includes focus-visible:(decoration-accent text-accent) on a <button>, which conflicts with the project rule to keep focus-visible styling for buttons/selects in global CSS. If you need accent styling on focus, extend the global rule instead.
Suggested change
- class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200"
+ class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) transition-colors duration-200"Based on learnings, “focus-visible styling for button and select elements is implemented globally in app/assets/main.css… Do not apply per-element inline utility classes like focus-visible:outline-accent/70 on these elements.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <button | |
| type="button" | |
| class="group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200" | |
| class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) focus-visible:(decoration-accent text-accent) transition-colors duration-200" | |
| @click.prevent="showModal" | |
| <button | |
| type="button" | |
| class="cursor-pointer group inline-flex gap-x-1 items-center justify-center underline-offset-[0.2rem] underline decoration-1 decoration-fg/30 font-mono text-fg hover:(decoration-accent text-accent) transition-colors duration-200" | |
| `@click.prevent`="showModal" |
|
This is a good change. How does the mobile menu match this thinking now? Are there any changes needed? |
|
@whitep4nth3r , I think in mobile version, there is no keyboard shortcuts options anywhere currently. It is only for desktop. |
There is one thing I want to say. We've added keyboard shortcuts in footer recently. Now in footer some items are related to within our app like about, privacy policy. Some footer items are external links which open in a new tab like docs.npmx.dev, chat.npmx.dev etc. And external links have also icon in the footer so that we can understand it is external. I think keyboard shortcuts is not external things. So I think we can group it together with the internal footer items like about and privacy policy. But currently keyboard shortcuts is with external links. So I think maybe it looks better if we rearrange this.
Before:

After:
