fix(ui): prevent compare with non-existing package

[MatteoGabriele]

closes #1198

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 8, 2026 0:36am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 8, 2026 0:36am
npmx-lunaria	Ignored		Feb 8, 2026 0:36am

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[coderabbitai]

📝 Walkthrough

Walkthrough

The Enter key handler in the package selector component was changed to trim the input and verify that the trimmed value matches an item in the current filtered results or corresponds to the No Dependency option before calling addPackage. Enter now only adds when the trimmed input is non-empty and a matching item or NO_DEPENDENCY_ID exists. No exported or public signatures were changed.

Suggested reviewers

• danielroe

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description references issue #1198, which relates directly to the changeset preventing non-existing packages from being added to the comparison table.
Linked Issues check	✅ Passed	The code changes implement the required functionality by adding validation to check for matching items in filtered results before allowing package additions, directly addressing the issue requirement.
Out of Scope Changes check	✅ Passed	All changes are scoped to the PackageSelector component and its tests, directly implementing the validation logic required to prevent adding non-existing packages.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Add an explicit guard before indexing emitted arrays.

Line 146–149 and Line 162–165 index into emitted without a concrete length check. This breaks the codebase’s strict type-safety guideline for array indexing.

Proposed fix

-      const emitted = component.emitted('update:modelValue')
-      expect(emitted).toBeTruthy()
-      expect(emitted![0]![0]).toEqual(['lodash'])
+      const emitted = component.emitted('update:modelValue') ?? []
+      expect(emitted.length).toBe(1)
+      expect(emitted[0]?.[0]).toEqual(['lodash'])

-      const emitted = component.emitted('update:modelValue')
-      expect(emitted).toBeTruthy()
-      expect(emitted![0]![0]).toEqual(['__no_dependency__'])
+      const emitted = component.emitted('update:modelValue') ?? []
+      expect(emitted.length).toBe(1)
+      expect(emitted[0]?.[0]).toEqual(['__no_dependency__'])

As per coding guidelines, "Ensure you write strictly type-safe code, for example by ensuring you always check when accessing an array value by index".

Also applies to: 162-165