Skip to content

feat: use default cursor for non-link items#1153

Closed
kalu5 wants to merge 3 commits intonpmx-dev:mainfrom
kalu5:feat/#1074
Closed

feat: use default cursor for non-link items#1153
kalu5 wants to merge 3 commits intonpmx-dev:mainfrom
kalu5:feat/#1074

Conversation

@kalu5
Copy link
Contributor

@kalu5 kalu5 commented Feb 7, 2026

resolves #1074

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 1:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 8, 2026 1:25pm
npmx-lunaria Ignored Ignored Feb 8, 2026 1:25pm

Request Review

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/ColumnPicker.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Removed the global button { cursor: pointer; } rule in app/assets/main.css and removed cursor-pointer utility classes from numerous Vue components (summary/details, selects, dropdown items, table headers, toggles, labels, etc.). No changes to control flow, event handlers, exported/public API signatures, or other styles noted in the diffs.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references issue #1074, which is directly related to the changeset removing cursor-pointer utility from non-link elements throughout the codebase.
Linked Issues check ✅ Passed All changes align with issue #1074 objectives: cursor-pointer has been systematically removed from non-link UI elements (buttons, selects, labels, dropdowns, summaries) across 19 files, reserving pointer cursor for actual links.
Out of Scope Changes check ✅ Passed All changes are within scope of issue #1074. The PR removes cursor-pointer exclusively from non-link interactive elements; no unrelated modifications to logic, functionality, or other styling properties were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
app/assets/main.css (1)

204-216: Good button reset and focus-visible styling.

The button reset (background: transparent; border: none; font: inherit; padding: 0;) is a standard normalisation pattern. The focus-visible rule for buttons and selects adds border-radius: 4px to round the focus outline, which complements the global :focus-visible rule at lines 189-196.

Note that the outline and outline-offset properties in lines 213-214 are redundant with the global rule (lines 194-195), which uses !important and will take precedence. Consider simplifying to only include border-radius: 4px if that's the intended addition.

🔧 Optional: Simplify to only the unique property
 button:focus-visible,
 select:focus-visible {
-  outline: 2px solid var(--accent);
-  outline-offset: 2px;
   border-radius: 4px;
 }

Removed custom button styles from main.css.
@alexdln
Copy link
Contributor

alexdln commented Feb 8, 2026

Hi @kalu5, you've closed the issue. Is there anything I can do to help?

The code is great btw, thanks for working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Use default cursor for non-link items

2 participants