webstreams: allow shared array buffer sources in writable adapter#62163
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
webstreams: allow shared array buffer sources in writable adapter#62163Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Renegade334
commented
Mar 9, 2026
Comment on lines
+235
to
+237
| if (!streamWritable.writableObjectMode && isAnyArrayBuffer(chunk)) { | ||
| chunk = new Uint8Array(chunk); | ||
| } |
Member
Author
There was a problem hiding this comment.
This operation can throw (if chunk is a detached array buffer), so should be within the try/catch block.
ad1a533 to
2d3e275
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62163 +/- ##
==========================================
- Coverage 89.65% 89.65% -0.01%
==========================================
Files 676 676
Lines 206543 206541 -2
Branches 39547 39554 +7
==========================================
- Hits 185184 185175 -9
- Misses 13480 13499 +19
+ Partials 7879 7867 -12
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webidl buffer source definition includes array buffers as well as array buffer views. Since node streams don't handle the former, #61913 added a transform step to the
Writable.toWebadapter to accept ArrayBuffers.This PR expands the adapter behaviour to include SharedArrayBuffers – since the adapter already accepts views on shared array buffers, it doesn't make much sense to exclude these asymmetrically from the adapter logic.