inspector: auto collect webstorage data

[islandryu]

Web Storage data collection, which previously required explicitly firing events to send data to DevTools, is now performed automatically within Node.js.
Web Storage will appear in DevTools simply by specifying --experimental-storage-inspection, without requiring any code changes.

This feature relies on the changes introduced in the following change request, so it can be verified with the latest DevTools commit:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7274801

[nodejs-github-bot]

Review requested:

• @nodejs/inspector

[codecov]

Codecov Report

❌ Patch coverage is 93.81443% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (a6e9e32) to head (8abbca3).
⚠️ Report is 91 commits behind head on main.

Files with missing lines	Patch %	Lines
src/inspector/dom_storage_agent.cc	83.33%	1 Missing and 6 partials ⚠️
src/node_webstorage.cc	77.27%	1 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62145      +/-   ##
==========================================
+ Coverage   89.64%   89.69%   +0.04%     
==========================================
  Files         676      677       +1     
  Lines      206240   206650     +410     
  Branches    39514    39568      +54     
==========================================
+ Hits       184891   185349     +458     
+ Misses      13465    13422      -43     
+ Partials     7884     7879       -5     

Files with missing lines	Coverage Δ
lib/internal/inspector/webstorage.js	100.00% <100.00%> (ø)
lib/internal/webstorage.js	100.00% <100.00%> (ø)
src/node_builtins.cc	76.33% <ø> (+0.38%)	⬆️
src/node_webstorage.h	83.33% <ø> (ø)
src/node_webstorage.cc	74.87% <77.27%> (+0.13%)	⬆️
src/inspector/dom_storage_agent.cc	68.25% <83.33%> (+18.57%)	⬆️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

Looks good!

I'd still recommend adding a test for UTF-16 characters outside the ISO-8859-1 range (e.g. emoji or Chinese characters)

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 404 Not Found

https://github.com/nodejs/node/actions/runs/22820941170

[aduh95]

Related test failure:

Path: parallel/test-code-cache
Error: --- stderr ---
node:internal/bootstrap/realm:185
      mod = bindingObj[module] = getInternalBinding(module);
                                 ^

Error: No such binding: webstorage

You probably need to skip that test when compiled without SQLite

[islandryu]

I changed the implementation to handle the storage keys and values as UTF-16.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71616/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71648/

[addaleax]

This is still making full copies – that's proably fine for a inspector feature, but it's an unnecessary set of extra allocations

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71656/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71693/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71742/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71743/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71761/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71769/

[islandryu]

@addaleax
I made a few changes to how the unordered_map is handled and added adjustments for environments where the inspector is not supported. Could you take another look?