Conversation
PR-URL: #61456 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #61573 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
Previously the resolve hook can be invoked twice from the synthetic module evaluation step of imported CJS in the extra module._load() call that's invoked on the resolved full path. Add an option to avoid it, since the resolution and loading has already been done before. PR-URL: #61529 Fixes: #57125 Refs: #55808 Refs: #56241 Reviewed-By: Jacob Smith <[email protected]>
Unifes assertSnapshot common patterns like platform specific path separators, line ending, line trailing spaces, Node.js version strings, and pids in warning messages. PR-URL: #61590 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>
PR-URL: #61603 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #61605 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61584 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tim Perry <[email protected]>
Use the `skipIfNoWatch()` utility function in `test/parallel/test-fs-promises-watch-iterator.js`. PR-URL: #61531 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #61602 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
The watch mode tests using runInBackground() had a race condition where stdout "Failed running" message could arrive before stderr was fully collected, causing assertions on stderr content to fail with empty strings. Fix by waiting for stderr 'data' event if stderr is empty when "Failed running" is detected. This is an event-driven approach rather than timing-based. Refs: nodejs/reliability#1450 PR-URL: #61615 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61617 Refs: #61316 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@8e8c483...de0fac2) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61619 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 10.1.0 to 10.1.1. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@5f858e3...9971854) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.1.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61620 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 8.0.0 to 8.1.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@98357b1...c0f553f) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 8.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61623 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Bumps [actions/cache](https://github.com/actions/cache) from 5.0.1 to 5.0.3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@9255dc7...cdf6c1f) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61624 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@395ad32...6044e13) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61625 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [cachix/cachix-action](https://github.com/cachix/cachix-action) from 0fc020193b5a1fa3ac4575aa3a7d3aa6a35435ad to 3ba601ff5bbb07c7220846facfa2cd81eeee15a1. - [Release notes](https://github.com/cachix/cachix-action/releases) - [Commits](cachix/cachix-action@0fc0201...3ba601f) --- updated-dependencies: - dependency-name: cachix/cachix-action dependency-version: 3ba601ff5bbb07c7220846facfa2cd81eeee15a1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61626 Refs: cachix/cachix-action@3ba601f Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@83679a8...a309ff8) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61627 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61551 Reviewed-By: Colin Ihrig <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.14.0 to 2.14.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@20cf305...e3f713f) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.14.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61621 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.9 to 4.32.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5d4e8d1...b20883b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #61622 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61375 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #61638 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Aviv Keller <[email protected]>
PR-URL: #61639 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Newer c-ares versions set tcp_port/udp_port to 53 instead of 0, which caused the loopback detection to fail. This fix: - Removes the port check from loopback detection - Adds IPv6 loopback (::1) support - Calls EnsureServers() before each DNS query PR-URL: #61453 Reviewed-By: Anna Henningsen <[email protected]>
The test was flaky because the histogram sampling might not have completed before the assertions ran. By using setImmediate before disabling the histogram and checking values, we give the event loop a chance to record final samples on slower systems. Also added an explicit check for histogram.count > 0 to provide a clearer error message if no samples are recorded. Refs: nodejs/reliability#1450 PR-URL: #61629 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #61649 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Corrected wording for clarity in README. PR-URL: #61653 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #61432 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Edy Silva <[email protected]>
PR-URL: #61562 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: #61730 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
github-actions
bot
added
release
Collaborator
|
Review requested:
|
aduh95
approved these changes
Feb 8, 2026
github-actions
bot
removed
the
request-ci
Collaborator
panva
approved these changes
Feb 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v25.x #61739 +/- ##
==========================================
+ Coverage 88.80% 89.71% +0.91%
==========================================
Files 679 681 +2
Lines 204193 204388 +195
Branches 39151 39271 +120
==========================================
+ Hits 181328 183364 +2036
+ Misses 15113 13318 -1795
+ Partials 7752 7706 -46 🚀 New features to boost your workflow:
|
RafaelGSS
approved these changes
Feb 8, 2026
Contributor
|
@legendecas I'm suspecting b064ddc to be the cause of the failures, could you take a look? |
Member
|
#61748 could be a fix |
PR-URL: #61685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]>
PR-URL: #61748 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
force-pushed
the
v25.6.1-proposal
branch
from
fbc836e to
43133f2
Compare
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v25.x #61739 +/- ##
==========================================
+ Coverage 88.80% 89.71% +0.91%
==========================================
Files 679 681 +2
Lines 204193 204388 +195
Branches 39151 39271 +120
==========================================
+ Hits 181328 183364 +2036
+ Misses 15113 13318 -1795
+ Partials 7752 7706 -46 🚀 New features to boost your workflow:
|
Collaborator
|
In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small release to address #61679
Commits
47df4328d7] - build,deps: replace cjs-module-lexer with merve (Yagiz Nizipli) #61456a727054503] - deps: upgrade npm to 11.9.0 (npm team) #61685c78c49ed6b] - deps: update amaro to 1.1.7 (Node.js GitHub Bot) #617304790816d9b] - deps: update minimatch to 10.1.2 (Node.js GitHub Bot) #617328c71740e8a] - deps: update undici to 7.21.0 (Node.js GitHub Bot) #61683e559ef6ab1] - deps: update googletest to 56efe3983185e3f37e43415d1afa97e3860f187f (Node.js GitHub Bot) #61605300de2bb5a] - deps: update amaro to 1.1.6 (Node.js GitHub Bot) #61603e71e9505ef] - dns: fix Windows SRV ECONNREFUSED by adjusting c-ares fallback detection (notvivek12) #61453439b816bc7] - doc: clarify EventEmitter error handling in threat model (Matteo Collina) #61701c1c6641f23] - doc: mention default option for test runner env (Steven) #6165941ec451f98] - doc: fix --inspect security warning section (Tim Perry) #61675bb90ef2356] - doc: documenturl.format(urlString)as deprecated under DEP0169 (René) #61644513df82e6f] - doc: update to Visual Studio 2026 manual install (Mike McCready) #616559409d30736] - doc: deprecation add more codemod (Augustin Mauroy) #6164275a7a67151] - doc: fix grammatical error in README.md (ayj8201) #61653821e59e884] - doc: correct tools README Boxstarter link (Mike McCready) #616384998f539a0] - doc: updateserver.dropMaxConnectionlink (YuSheng Chen) #615849383ac4ab7] - http: implement slab allocation for HTTP header parsing (Mert Can Altin) #61375e90eb1d561] - meta: persist sccache daemon until end of build workflows (René) #61639ade36ac367] - meta: bump github/codeql-action from 4.31.9 to 4.32.0 (dependabot[bot]) #6162226638bd67f] - meta: bump step-security/harden-runner from 2.14.0 to 2.14.1 (dependabot[bot]) #61621eaa9a96cb6] - meta: bump actions/setup-python from 6.1.0 to 6.2.0 (dependabot[bot]) #61627fd98187828] - meta: bump cachix/cachix-action (dependabot[bot]) #61626820c1d021c] - meta: bump actions/setup-node from 6.1.0 to 6.2.0 (dependabot[bot]) #6162572a4136bd5] - meta: bump actions/cache from 5.0.1 to 5.0.3 (dependabot[bot]) #61624e3ef6cb3bc] - meta: bump peter-evans/create-pull-request from 8.0.0 to 8.1.0 (dependabot[bot]) #61623020a836202] - meta: bump actions/stale from 10.1.0 to 10.1.1 (dependabot[bot]) #616200df72f07c8] - meta: bump actions/checkout from 6.0.1 to 6.0.2 (dependabot[bot]) #61619d147c08b83] - module: do not invoke resolve hooks twice for imported cjs (Joyee Cheung) #61529a2843f8556] - net: defer synchronous destroy calls in internalConnect (RajeshKumar11) #616587fb7030781] - repl: fix flaky test-repl-programmatic-history (Matteo Collina) #61614d4c9b5cf5b] - sqlite: avoid extra copy for large text binds (Ali Hassan) #61580aa1b3661d9] - sqlite: use DictionaryTemplate for run() result (Mert Can Altin) #614329c8ad7e881] - src: elide heap allocation in structured clone implementation (Anna Henningsen) #61703c4ecfef93d] - src: use simdutf for one-byte string UTF-8 write in stringBytes (Mert Can Altin) #6169628905b9734] - src: consolidate C++ ReadFileSync/WriteFileSync utilities (Joyee Cheung) #61662e90cec2f69] - test: restraint version replacement pattern in snapshots (Chengzhong Wu) #61748adce20c0a1] - test: print stack immediately avoiding GC interleaving (Chengzhong Wu) #616997643bc8999] - test: fix case-insensitive path matching on Windows (Matteo Collina) #6168223d1ecf66f] - test: fix flaky test-performance-eventloopdelay (Matteo Collina) #6162999012a88ed] - test: remove duplicate wpt tests (Filip Skokan) #61617a8b32b8ce1] - test: fix race condition in watch mode tests (Matteo Collina) #61615086a5a5a25] - test: update WPT for url to e3c46fdf55 (Node.js GitHub Bot) #61602f0574fd419] - test: use the skipIfNoWatch() utility function (Luigi Pinca) #61531b064ddc221] - test: unify assertSnapshot common patterns (Chengzhong Wu) #6159017122e521b] - test_runner: fix test enqueue when test file has syntax error (Edy Silva) #61573bad3f02dd9] - tools: enforce removal oflts-watch-*labels on release proposals (Antoine du Hamel) #61672a8f33fd6bd] - tools: use ubuntu-slim runner in meta GitHub Actions (Tierney Cyren) #61663c843e447ca] - tools: test--shared-merveintest-sharedworkflow (Antoine du Hamel) #616492fedc03f96] - tools: update OpenSSL to 3.5.5 intest-shared(Antoine du Hamel) #615511c1db94670] - tools,win: upgrade install additional tools to Visual Studio 2026 (Mike McCready) #61562