Skip to content

[Snyk] Security upgrade qn from 0.2.2 to 1.3.0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gxcsoccer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade qn from 0.2.2 to 1.3.0 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"dependencies": {
"bagpipe": "~0.3.5",
"optimist": "~0.6.1",
"qn": "~0.2.2",
"qn": "~1.3.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade from qn version 0.2.2 to 1.3.0 does not resolve the identified security vulnerability and introduces a breaking change.

Security Vulnerability

The Snyk report indicates this change is to fix a ReDoS vulnerability in the mime package (npm:mime:20170907). This vulnerability affects versions of mime prior to 1.4.1.

Since [email protected] is still less than 1.4.1, the project remains vulnerable even after this upgrade.

Breaking Change

This version bump is a major version change (0.x to 1.x) and introduces a breaking change in the qnClient.upload() method's callback signature. This will break the shotQN functionality in this library.

Recommendation

The qn package has not been updated in over 7 years and should be considered unmaintained. The recommended course of action is to migrate to the official Qiniu SDK, qiniu, to resolve this and other potential security issues.

Because this PR does not fix the vulnerability and introduces a breaking change, it should be closed. A new issue should be created to track the migration from qn to qiniu.

"utility": "~0.1.16"
},
"devDependencies": {
Expand Down
Loading