Open
Conversation
TanYiQing
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
Contributor
zhindes
requested changes
Feb 13, 2026
Collaborator
zhindes
left a comment
zhindes
left a comment
There was a problem hiding this comment.
Also your PR description is all boilerplate.
|
|
||
| ## 1.4.1 | ||
| * ### Merged Pull Requests | ||
| * [Full changelog: 1.4.0...1.4.1](https://github.com/ni/nidaqmx-python/compare/1.3.0...1.4.1) |
Collaborator
Author
There was a problem hiding this comment.
Yes, the link should be 1.4.0…1.4.1. There is a mistake here, and I will correct it in the next commit.
bkeryan
reviewed
Feb 13, 2026
| license = "MIT" | ||
| keywords = ["nidaqmx", "nidaq", "daqmx", "daq"] | ||
| version = "1.4.1.dev0" | ||
| version = "1.4.1" |
Collaborator
There was a problem hiding this comment.
There have been no changes in releases/1.4 since the 1.4.0 release. Are you going to cherry-pick #924 ?
Collaborator
Author
There was a problem hiding this comment.
Yes correct, #924 just merged, and it will be cherry-picked.
Collaborator
There was a problem hiding this comment.
Ok. Please also update CHANGELOG.md in the main branch to list 1.5.0 and 1.4.1, with #924 listed under 1.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
TODO: Check the above box with an 'x' if considered if there were any and then documented client facing changes in CHANGELOG.md. Strike through if this is not a relevant client facing change.
TODO: Check the above box with an 'x' indicating you have considered and added any applicable system or unit tests. Strike through if you considered and decided additional tests were not warranted.
What does this Pull Request accomplish?
Update version of pyproject.toml in releases/1.4 branch to 1.4.1.
Why should this Pull Request be merged?
Prepare for nidaqmx-python 1.4.1 release.
What testing has been done?
N/A