Move "Root Actor is Loaded.vi" to AFPP Shared Library#122
Open
neilfenstein wants to merge 24 commits intoni:feature/50-move-root-actor-class-is-loadedvi-to-afpp-sharedlvlibfrom
Open
Move "Root Actor is Loaded.vi" to AFPP Shared Library#122neilfenstein wants to merge 24 commits intoni:feature/50-move-root-actor-class-is-loadedvi-to-afpp-sharedlvlibfrom
neilfenstein wants to merge 24 commits intoni:feature/50-move-root-actor-class-is-loadedvi-to-afpp-sharedlvlibfrom
Conversation
…ation. Deleted deprecated package builds (builds 12 and 17). Added build 18.
Resolves issue 31, 32, and 33.
…messages-pallete Resolved issue ni#28
…ared Lib Relocated on disk Update the icon to show AFPP Header
Contributor
|
@neilfenstein can you please sign your commits? This is a blog post from SAS Workshops that explains how to do that. |
… develop # Conflicts: # Builds/actor_framework_2024_for_2020-2.0.0.18.vip # Core/Actor Framework 2024 for 2020.vipb
# Conflicts: # Documentation/Manual Test Scripts/Manual Test Script for Actor Framework Project Providers.docx
Author
|
I had to update my code with an alias file change and the .tgitignore file to get a sign commit, let me know if this is OK, if not I can re-fork and commit the changes signed. |
Contributor
|
i haven't lost track of this @neilfenstein . AF has foundational CI only and no release pipeline, i am planning on introducing it very soon. |
…or-to-the-open-source-repository Feature/49 add state pattern actor to the open source repository
Revert "Merge pull request ni#140 from niACS/feature/49-add-state-patte…
Collaborator
|
@neilfenstein Did you run the manual test plan for the providers, here: https://github.com/ni/actor-framework/blob/develop/Documentation/Manual%20Test%20Scripts/Manual%20Test%20Script%20for%20Actor%20Framework%20Project%20Providers.docx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue for the Pull Request
Issue 50
GitHub Discussions Related to this Pull Request
List any GitHub discussion links related to this PR
Checklists
Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.
Summary of Changes
Moved Root Actor is Loaded.vi from Message Maker Library to AFPP Shared Library.
Reason for Change
Reduction of Library linkage.
Visual Aids
Dependency linkage before work
Dependency linkage after work
Updated Icon and Library Namespace visual
Location in AFPP Shared Library
Additional Information
Include any further details that may assist the reviewer in understanding the context of this PR.
Testing
This section describes the automated and manual tests performed for this bugfix/feature.
Manual Tests
Created new project and added the vi before moved and repeated after moved as shown in the screen shots above.