Fix(signaling): ignore ECONNABORTED errors to prevent conversation not found#17158
Open
Paulcor35 wants to merge 3 commits intonextcloud:mainfrom
Open
Fix(signaling): ignore ECONNABORTED errors to prevent conversation not found#17158Paulcor35 wants to merge 3 commits intonextcloud:mainfrom
Paulcor35 wants to merge 3 commits intonextcloud:mainfrom
Conversation
…t found Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
Antreesy
approved these changes
Feb 18, 2026
Contributor
There was a problem hiding this comment.
Otherwise a good addition. Can reproduce locally with small patch (axios aborts request with this code when timeout, and in other cases) + Internal signaling
--- a/src/services/signalingService.js (revision 972b65935d05780ec33a7337a4c28aab0d6fc9e7)
+++ b/src/services/signalingService.js (date 1771412086368)
@@ -26,7 +26,7 @@
* @param options
*/
async function pullSignalingMessages(token, options) {
- return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), options)
+ return axios.get(generateOcsUrl('apps/spreed/api/v3/signaling/{token}', { token }), { timeout: 1 })
}
Contributor
|
Looping @danxuliu for a second opinion |
added 2 commits
February 18, 2026 12:05
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
Signed-off-by: CORNEN Paul <paul.cornen2@soprasteria.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t found
☑️ Resolves
Prevents the "Conversation not found" error page when a temporary network interruption (ECONNABORTED) occurs.
Previously, if a polling request was aborted (e.g., refreshing the page or unstable network), the user was kicked out of the conversation. This patch ignores ECONNABORTED errors just like we ignore isCancel.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Screenshot before

Screenshot after
No UI changes. The conversation loads normally instead of showing the "Conversation not found" error.
🚧 Tasks
🏁 Checklist