Skip to content

refactor(chat): import mdi icons#13340

Closed
ShGKme wants to merge 2 commits intomainfrom
chore/mdi-js-icon
Closed

refactor(chat): import mdi icons#13340
ShGKme wants to merge 2 commits intomainfrom
chore/mdi-js-icon

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 18, 2024

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Antreesy
Copy link
Contributor

Antreesy commented Sep 19, 2024

Is it correctly tree-shakes the lib? I thought about that, but didn't want to add a 3Mb library just for 7 strings

@ShGKme ShGKme marked this pull request as draft September 19, 2024 14:39
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 19, 2024

Is it correctly tree-shakes the lib? I thought about that, but didn't want to add a 3Mb library just for 7 strings

Hmm... It must work fine, and on server it does. But in Talk it doesn't, and I do not understand, why

@nickvergessen
Copy link
Member

/backport to stable30

@Antreesy
Copy link
Contributor

Antreesy commented Oct 9, 2024

Found server PR: nextcloud/server#43488
Looked at the upstream issue, it might be that esbuild is the reason it's not minified

@Antreesy
Copy link
Contributor

Superseded by #14870

@Antreesy Antreesy closed this Apr 14, 2025
@Antreesy Antreesy removed this from the πŸͺΊ Next Major (32) milestone Apr 14, 2025
@nickvergessen nickvergessen deleted the chore/mdi-js-icon branch December 11, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants