-
Notifications
You must be signed in to change notification settings - Fork 173
let the user choose his Bitcoin implementation on first boot #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rootfs/standard/var/www/mynode/templates/choose_bitcoin_implementation.html
Outdated
Show resolved
Hide resolved
|
Here some lines to start from. Improving / replacing them - by all means, please. Core pros
Knots pros
|
|
updating to Knots |
|
@tehelsper any thoughts on this? |
|
To be honest, I don't love it because newer people to Bitcoin have no idea what the different implementations mean. My current plan is to keep the initial setup simple and then let people explore and make changes as they learn more. Either implementation can perform the initial sync and there should be no issues swapping once synced, so my currently plan is to keep Core (either an pre-30 version or one along with a default config that limits OP_RETURN sizes) as default just to keep things simple. As an aside, there seems to be an issue with the latest Knots that prevents Electrum from syncing quickly. It may also be present in newer Core releases, but I have not investigated yet. |
|
Please note that datacarriersize=83 in v29.1 != datacarriersize=83 in v30, Core basically broke datacarriersize entirely. Anyway, it's strongly advised to not use v30/v30.1 as per bitcoin core words |
|
Thanks! I had heard about that bug and was not planning on updating anytime soon to 30+. I did not know about the datacarriersize differences though - I'll have to look into that more since I had assumed eventually going to 30+ along with changing that option would be more or less reverting it to behavior similar to <=29. |
|
Check here bitcoin/bitcoin#32406 (comment) to learn more. |

close #969
Checklist
List of test device(s)
VM
Description
This is a draft and it's not functional yet, I'm just opening it now to avoid duplicate work