Skip to content

fix(windows): Fix Windows build and enable multi-version wheel support#9

Merged
munlicode merged 1 commit intomunlicode:mainfrom
yzhuang-els:fix/windows-build
Feb 21, 2026
Merged

fix(windows): Fix Windows build and enable multi-version wheel support#9
munlicode merged 1 commit intomunlicode:mainfrom
yzhuang-els:fix/windows-build

Conversation

@yzhuang-els
Copy link
Contributor

  • add ssize_t typedef for msvc (fasttext_pybind.cc)
  • add /std:c++17 flag for msvc (setup.py)
  • make -pthread and -march=native conditional on non-windows (CMakeLists.txt)
  • fix signed/unsigned comparison in src/loss.cc
  • fix NamedTemporaryFile exclusive lock breaking tests on windows (test_script.py)
  • add [tool.cibuildwheel] config for amd64-only windows wheels across cp39–cp313
  • re-enable windows-latest in ci and release workflows

closes #1

- Add ssize_t typedef for MSVC in fasttext_pybind.cc (POSIX type missing on Windows)
- Add /std:c++17 flag for MSVC in setup.py (was only set for GCC/Clang)
- Make -pthread and -march=native flags conditional on non-Windows in CMakeLists.txt
- Fix signed/unsigned comparison in src/loss.cc (int32_t vs size_t)
- Fix NamedTemporaryFile exclusive lock on Windows in test_supervised_util_test
- Add [tool.cibuildwheel] config to pyproject.toml (AMD64 only, cp39-cp313)
- Re-enable windows-latest in ci.yml and release.yml workflows
@munlicode munlicode merged commit 5172042 into munlicode:main Feb 21, 2026
6 checks passed
@munlicode
Copy link
Owner

Thanks for contribution. It is a huge help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows build fails with compiler warnings/errors

2 participants