Skip to content

🔧 Improve configuration of prek hooks#1498

Merged
burgholzer merged 1 commit intomainfrom
improve-prek
Feb 2, 2026
Merged

🔧 Improve configuration of prek hooks#1498
burgholzer merged 1 commit intomainfrom
improve-prek

Conversation

@denialhaag
Copy link
Member

Description

This PR slightly improves the definitions of two prek hooks, in line with suggestions from CodeRabbit.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Feb 2, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file pre-commit Any updates related to pre-commit labels Feb 2, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Refined pre-commit hook configuration for improved code quality checks and consistency.
    • Optimized development tooling settings to enhance accuracy and efficiency in automated validation workflows.

Walkthrough

Modified .pre-commit-config.yaml to refine the disallow-caps hook's regex pattern from an alternative list to a word-boundary-anchored pattern, narrowed the exclude rule to target only this configuration file, and added pass_filenames: false to the ty-check hook.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Updated disallow-caps regex pattern to use word boundaries (\b(Nanobind|Numpy|Cmake|CCache|Github|PyTest|Mqt|Tum)\b), restricted its exclude rule to only .pre-commit-config.yaml, and added pass_filenames: false to ty-check local hook.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

code quality

Suggested reviewers

  • burgholzer

Poem

🐰 With whiskers twitched and nose held high,
I refine the regex, no need to ask why—
Word boundaries reign where caps once sprawled,
Pre-commit hooks polished, the linter's called! ✨
A tidier config, more precise and right,
Hops of approval through the night! 🌙

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses an emoji and references improving 'prek' hooks, which aligns with the changes to .pre-commit-config.yaml, but 'prek' is unclear and the emoji adds noise. Consider using a clearer title like 'Improve pre-commit hook configurations' or 'Refine disallow-caps and ty-check hook settings' to be more specific about the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes a brief summary and a properly formatted checklist with appropriate items marked complete or skipped, meeting the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch improve-prek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@denialhaag
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@denialhaag denialhaag requested a review from burgholzer February 2, 2026 13:51
@burgholzer burgholzer merged commit a391783 into main Feb 2, 2026
20 of 21 checks passed
@burgholzer burgholzer deleted the improve-prek branch February 2, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pre-commit Any updates related to pre-commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants