Allow overiding of pub_addr and sub_addr. Ignore mongrel sql if config_db is not set.#15
Open
larubbio wants to merge 5 commits intomongrel2:masterfrom
Open
Allow overiding of pub_addr and sub_addr. Ignore mongrel sql if config_db is not set.#15larubbio wants to merge 5 commits intomongrel2:masterfrom
larubbio wants to merge 5 commits intomongrel2:masterfrom
Conversation
These could use some refactoring since they are now coded to depend on some implementation details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also in this pull request are changes to the tests to align them with the code and get them passing. They could use another pass through since they are now using other methods within tir to set the pre-state so they are pretty fragile.