fix: add StatelessModeNotSupported exception and improve tests #1828
+132
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address review feedback from PR #1827: - Create StatelessModeNotSupported exception that inherits from RuntimeError - Replace _require_stateful_mode() helper with inline checks in each method - Add match= parameter to pytest.raises() calls for more specific error matching - Create stateless_session and stateful_session fixtures to reduce test boilerplate - Add test for exception's method attribute Claude-Generated-By: Claude Code (cli/claude-opus-4-5=100%) Claude-Steers: 7 Claude-Permission-Prompts: 26 Claude-Escapes: 1
Kludex
approved these changes
Jan 5, 2026
Member
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
This looks better. 👍
Please read my comment on the other PR, but feel free to do what you think is best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address review feedback from PR #1827 that was auto-merged before comments could be addressed.
Motivation and Context
PR #1827 introduced stateless mode error handling but received review feedback from @Kludex that couldn't be addressed before auto-merge. This PR implements that feedback:
_require_stateful_mode()helper with a specificStatelessModeNotSupportedexception and inline checksmatch=parameter topytest.raises()calls for more specific error matchingHow Has This Been Tested?
Breaking Changes
None -
StatelessModeNotSupportedinherits fromRuntimeError, so existing code catchingRuntimeErrorwill continue to work.Types of changes
Checklist
Additional context
Changes made:
StatelessModeNotSupportedexception tomcp.shared.exceptions_require_stateful_mode()helper with inline checks inServerSessionstateless_sessionandstateful_sessionfixtures in testsmatch=to allpytest.raises()callsmethodattribute