fix chunking equal number of videos for each thread.#40
Open
pulinagrawal wants to merge 1 commit intomit-han-lab:masterfrom
Open
fix chunking equal number of videos for each thread.#40pulinagrawal wants to merge 1 commit intomit-han-lab:masterfrom
pulinagrawal wants to merge 1 commit intomit-han-lab:masterfrom
Conversation
|
That's one way but I think the following way is nicer since a single thread processes contiguous array elements (from which it is easier to trace any errors which might have occurred during the process): def split(xs, n):
"""Yields n roughly even-sized chunks from xs."""
size = len(xs)
q = size // n
r = size % n
offset = 0
for i in range(r):
yield xs[offset : offset + (q + 1)]
offset += q + 1
for i in range(n - r):
yield xs[offset : offset + q]
offset += q
assert offset == sizeOne should also sort the list of files beforehand via: video_list = os.listdir(VIDEO_ROOT)
video_list.sort(key=lambda x: int(x.split(".")[0]))EDIT: On the other hand, your method makes it so that the dataset is mostly processed "in order", assuming the threads are roughly synced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously NUM_THREADS sized chunks were created out of the videos list. Now NUM_THREADS chunks of almost equal size are created.