mana: don't leak VFIO handle when we fail to save #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a resource leak where the VFIO device handle was unconditionally leaked even when saving the MANA device state failed. The fix ensures that on save failure, the device handle is properly dropped after attempting to reset the device via FLR.
Changes:
- Conditional leaking of VFIO handle only on successful save operations
- Explicit device handle drop on save failure after FLR reset attempt
- Enhanced error logging with structured error information
Brian-Perkins
approved these changes
Jan 29, 2026
chris-oo
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we always leak the VFIO device handle even if save fails. While I think we would recover the device on the other end of servicing, we can make it more explicit by doing the same thing we do in
shutdown_vtl2_devicewhen the device is in a bad state.