Fix string slicing for fs.write #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
commented
Dec 15, 2025
Closed
Tyriar
requested changes
Dec 16, 2025
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Seems to bring back the notorious interleaving bug:
Tyriar
requested changes
Dec 16, 2025
Tyriar
requested changes
Dec 16, 2025
Tyriar
requested changes
Dec 16, 2025
Member
This is only for cooked mode, will follow that up in new PR #833 (comment) |
Tyriar
approved these changes
Dec 17, 2025
Member
Author
|
Thanks for fixing up my PR! |
This was referenced Dec 17, 2025
alexr00
approved these changes
Dec 17, 2025
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Dec 19, 2025
Brings in further improvements to handling of write backpressure. After this we no longer throttle at all which means that for older versions of bash at least on macOS interleaving is possible, but pasting and sending should be near instantaneous for any reasonable amount of text. I measured zsh injesting 5mb of data in ~14 seconds. See: - microsoft/node-pty#835 - microsoft/node-pty#837 - microsoft/node-pty#839 Part of #246204, #283056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains my spin on #831. The difference is it wraps any input as
Bufferfirst and lacks a_writeInProgressfield. This fixes a bug in #831 where thewrittencallback parameter is used to slice string arguments even though it's probably meant for byte counts.