Skip to content

bugfix for lancedb uri parsing when using an object store #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-sajid-ali wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix for lancedb uri parsing when using an object store #2192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/graphrag/graphrag/config/models/graph_rag_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,11 @@ def _validate_vector_store_db_uri(self) -> None:
"""Validate the vector store configuration."""
store = self.vector_store
if store.type == VectorStoreType.LanceDB:
if not store.db_uri or store.db_uri.strip == "":
if not store.db_uri or store.db_uri.strip() == "":
store.db_uri = graphrag_config_defaults.vector_store.db_uri
store.db_uri = str(Path(store.db_uri).resolve())
# Only convert to a filesystem path if the URI is not for object store
if not store.db_uri.startswith(("az://", "s3://", "gs://")):
store.db_uri = str(Path(store.db_uri).resolve())

def get_completion_model_config(self, model_id: str) -> ModelConfig:
"""Get a completion model configuration by ID.
Expand Down