cleanup: cleanup for virtio networking dns #14111
Merged
+86
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors DNS update handling across WSL networking modes (NAT, Mirrored, and VirtioProxy) to consolidate common logic and fix a bug where VirtioProxy networking would only send DNS updates once during initialization and not when host DNS information changed.
Changes:
- Introduced
BuildDnsNotification()helper function to centralize DNS notification message construction fromDnsInfosettings - Added
DnsUpdateHelperclass to fetch current DNS settings from the host - Removed DNS-related fields (
DnsServers,DeviceName) fromNetworkSettingsstruct as they are now fetched dynamically - Fixed VirtioProxy to track DNS changes and send updates when host DNS information changes via network connectivity callbacks
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/windows/common/WslCoreHostDnsInfo.h | Added BuildDnsNotification() function declaration and DnsUpdateHelper class for fetching current DNS settings |
| src/windows/common/WslCoreHostDnsInfo.cpp | Implemented BuildDnsNotification() to convert DnsInfo to hns::DNS notification and DnsUpdateHelper::GetCurrentDnsSettings() |
| src/windows/common/WslCoreNetworkEndpointSettings.h | Removed DNS-related fields (DnsServers, DeviceName) from NetworkSettings struct and simplified constructor |
| src/windows/common/WslCoreNetworkEndpointSettings.cpp | Removed DNS initialization code from GetHostEndpointSettings() as DNS is now fetched dynamically |
| src/windows/common/VirtioNetworking.h | Changed DNS handling to use DnsUpdateHelper and track DNS state with m_trackedDnsSettings |
| src/windows/common/VirtioNetworking.cpp | Implemented DNS change tracking and updates in RefreshGuestConnection() callback; refactored to use BuildDnsNotification() |
| src/windows/service/exe/WslMirroredNetworking.cpp | Removed duplicate ConvertDnsInfoToHnsSettingsMsg() function; now uses shared BuildDnsNotification() |
| src/windows/common/NatNetworking.cpp | Refactored to use BuildDnsNotification() instead of inline DNS notification construction |
OneBlue
approved these changes
Jan 27, 2026
OneBlue
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up how DNS update messages are handled between NAT, Mirrored, and VirtioProxy networking modes. It also resolves an issue with VirtioProxy networking would update DNS information once and not send updates if the host information changed.