WSLA tests: switch from WI_SetFlagIf to WI_UpdateFlag to maintain cor… #14106
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect behavior if defaults change
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WSLA Windows tests to use flag updates that preserve correctness when defaults change, ensuring tests explicitly set/clear feature flags based on the test scenario rather than only conditionally setting them.
Changes:
- Replace
WI_SetFlagIfwithWI_UpdateFlagso feature flags are correctly set or cleared based on the boolean inputs. - Apply this to early-boot dmesg logging, DNS tunneling, and VirtioFS-related test helpers.
OneBlue
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup I noticed while experimenting with testing the WSLA tests with different default options. The good news is that all the tests pass with all combinations of our feature flags :)